fix(connector-besu): set contract bytecode field's max length to 49154

Prior to this commit the Besu connector's API validated requests when deploying solidity contracts via their bytecode such that the length of the bytecode parameter cannot be longer than 24576 characters, but instead it should have an upper limit of 49154 characters because each byte is represented as two characters in hex. See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit." Fixes hyperledger-cacti#3636 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz · Nov 26, 2024 · d0e6397 · d0e6397
1 parent 27a24dd
commit d0e6397
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 18 deletions.
diff --git a/...tus-plugin-ledger-connector-besu/src/main/go/generated/openapi/go-client/api/openapi.yaml b/...tus-plugin-ledger-connector-besu/src/main/go/generated/openapi/go-client/api/openapi.yaml
@@ -1041,8 +1041,10 @@ components:
           $ref: '#/components/schemas/Web3SigningCredential'
         bytecode:
           description: See https://ethereum.stackexchange.com/a/47556 regarding the
-            maximum length of the bytecode
-          maxLength: 24576
+            maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex
+            stores each byte in 2 characters and that there is a 0x prefix (2 characters)
+            which does not count towards the EVM 24576 bytecode limit.
+          maxLength: 49154
           minLength: 1
           nullable: false
           type: string
@@ -1117,8 +1119,10 @@ components:
           $ref: '#/components/schemas/Web3SigningCredential'
         bytecode:
           description: See https://ethereum.stackexchange.com/a/47556 regarding the
-            maximum length of the bytecode
-          maxLength: 24576
+            maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex
+            stores each byte in 2 characters and that there is a 0x prefix (2 characters)
+            which does not count towards the EVM 24576 bytecode limit.
+          maxLength: 49154
           minLength: 1
           nullable: false
           type: string

diff --git a/...rated/openapi/go-client/model_deploy_contract_solidity_bytecode_no_keychain_v1_request.go b/...rated/openapi/go-client/model_deploy_contract_solidity_bytecode_no_keychain_v1_request.go
diff --git a/...main/go/generated/openapi/go-client/model_deploy_contract_solidity_bytecode_v1_request.go b/...main/go/generated/openapi/go-client/model_deploy_contract_solidity_bytecode_v1_request.go
diff --git a/packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json b/packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.json
@@ -731,8 +731,8 @@
             "type": "string",
             "nullable": false,
             "minLength": 1,
-            "maxLength": 24576,
-            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode"
+            "maxLength": 49154,
+            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit."
           },
           "keychainId": {
             "type": "string",
@@ -798,8 +798,8 @@
             "type": "string",
             "nullable": false,
             "minLength": 1,
-            "maxLength": 24576,
-            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode"
+            "maxLength": 49154,
+            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit."
           },
           "gas": {
             "type": "number",

diff --git a/packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json b/packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json
@@ -731,8 +731,8 @@
             "type": "string",
             "nullable": false,
             "minLength": 1,
-            "maxLength": 24576,
-            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode"
+            "maxLength": 49154,
+            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit."
           },
           "keychainId": {
             "type": "string",
@@ -798,8 +798,8 @@
             "type": "string",
             "nullable": false,
             "minLength": 1,
-            "maxLength": 24576,
-            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode"
+            "maxLength": 49154,
+            "description": "See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit."
           },
           "gas": {
             "type": "number",

diff --git a/...enerated/openapi/models/deploy_contract_solidity_bytecode_no_keychain_v1_request_pb.proto b/...enerated/openapi/models/deploy_contract_solidity_bytecode_no_keychain_v1_request_pb.proto
@@ -29,7 +29,7 @@ message DeployContractSolidityBytecodeNoKeychainV1RequestPB {
 
   Web3SigningCredentialPB web3SigningCredential = 451211679;
 
-  // See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode
+  // See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit.
   string bytecode = 256554254;
 
   float gas = 102105;

diff --git a/...main/proto/generated/openapi/models/deploy_contract_solidity_bytecode_v1_request_pb.proto b/...main/proto/generated/openapi/models/deploy_contract_solidity_bytecode_v1_request_pb.proto
@@ -29,7 +29,7 @@ message DeployContractSolidityBytecodeV1RequestPB {
 
   Web3SigningCredentialPB web3SigningCredential = 451211679;
 
-  // See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode
+  // See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit.
   string bytecode = 256554254;
 
   // The keychainId for retrieve the contracts json.

diff --git a/...lugin-ledger-connector-besu/src/main/typescript/generated/openapi/typescript-axios/api.ts b/...lugin-ledger-connector-besu/src/main/typescript/generated/openapi/typescript-axios/api.ts
@@ -176,7 +176,7 @@ export interface DeployContractSolidityBytecodeNoKeychainV1Request {
      */
     'web3SigningCredential': Web3SigningCredential;
     /**
-     * See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode
+     * See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit.
      * @type {string}
      * @memberof DeployContractSolidityBytecodeNoKeychainV1Request
      */
@@ -237,7 +237,7 @@ export interface DeployContractSolidityBytecodeV1Request {
      */
     'web3SigningCredential': Web3SigningCredential;
     /**
-     * See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode
+     * See https://ethereum.stackexchange.com/a/47556 regarding the maximum length of the bytecode. 2 + (24576 * 2) = 49154 meaning that hex stores each byte in 2 characters and that there is a 0x prefix (2 characters) which does not count towards the EVM 24576 bytecode limit.
      * @type {string}
      * @memberof DeployContractSolidityBytecodeV1Request
      */