Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Implement support for parameter attributes for bindings. #457

Open
peterhuene opened this issue Nov 12, 2019 · 0 comments
Open

Implement support for parameter attributes for bindings. #457

peterhuene opened this issue Nov 12, 2019 · 0 comments
Assignees
Labels
awaiting release The issue has been resolved in the dev branch and is awaiting the next release to close. enhancement New feature or request
Milestone

Comments

@peterhuene
Copy link
Owner

Now that 1.39.0 supports parameter attributes, move the #[binding(...)] macros to the parameters.

@peterhuene peterhuene added enhancement New feature or request breaking change The resolution to the issue will be considered a breaking change. labels Nov 12, 2019
@peterhuene peterhuene added this to the 0.12.0 milestone Nov 12, 2019
@peterhuene peterhuene self-assigned this Nov 12, 2019
@peterhuene peterhuene added blocked Issue is currently blocked. and removed breaking change The resolution to the issue will be considered a breaking change. blocked Issue is currently blocked. labels Nov 14, 2019
peterhuene added a commit that referenced this issue Nov 14, 2019
This commit implements support for binding attributes on parameters.

For example:

```rust
pub fn foo(#[binding(route = "foo") req: HttpRequest) {
}
```

However, both `rustfmt` and `rls` (plus GitHub's source parser) do not yet
properly handle attributes on parameters.

The samples and documentation will be updated to specify the attributes on the
parameters themselves once there is broader support of the feature.

Closes #457.
peterhuene added a commit that referenced this issue Nov 14, 2019
This commit implements support for binding attributes on parameters.

For example:

```rust
pub fn foo(#[binding(route = "foo") req: HttpRequest) {
}
```

However, both `rustfmt` and `rls` (plus GitHub's source parser) do not yet
properly handle attributes on parameters.

The samples and documentation will be updated to specify the attributes on the
parameters themselves once there is broader support of the feature.

Closes #457.
@peterhuene peterhuene added the awaiting release The issue has been resolved in the dev branch and is awaiting the next release to close. label Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting release The issue has been resolved in the dev branch and is awaiting the next release to close. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant