Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up payments panel #35

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Clean up payments panel #35

merged 4 commits into from
Nov 11, 2022

Conversation

maxwellward
Copy link
Collaborator

@maxwellward maxwellward commented Nov 10, 2022

  • Removes redundant title for payments panel.
  • Changes title of gifted nitro to be explanatory enough to not need an info card.
  • Changes "at" to "on" to be grammatically correct.
  • Fixes rounding of currency to be a maximum of 2 decimal places.
  • Change the symbol references in currencies.json to be the actual symbol as basically all modern browsers can display the normal symbols.
  • Currency symbol is now returned from getMostUsedCurrency to clean up the payments panel code a bit.

Closes #33

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for discordpackage ready!

Name Link
🔨 Latest commit 75e9479
🔍 Latest deploy log https://app.netlify.com/sites/discordpackage/deploys/636c94291ecfdf0009fcdd06
😎 Deploy Preview https://deploy-preview-35--discordpackage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@peterhanania peterhanania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterhanania peterhanania merged commit 4af3358 into peterhanania:main Nov 11, 2022
@maxwellward maxwellward deleted the clean-up-payments-panel branch November 11, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Your payments" section does not round total spending
2 participants