Move the audit append path into Base by peterdrier · Pull Request #2253 · peterdrier/Humans

peterdrier · 2026-11-02T23:08:20Z

Requested by Peter · project thread

What

PR 2 of 4 (after #2252). IAuditLogService (with AuditLogEntrySnapshot) and AuditActionDefinition with IAuditActionContributor / AuditActionContributor move from Humans.AuditLog/Contracts/ to src/Humans.Base/AuditLog/. Namespace stays Humans.AuditLog.Contracts (Peter's call for this series), so no using changes.

54 projects drop their Humans.AuditLog reference (30 src, including Email.Contracts and Finance.Contracts, plus test projects). In src, AuditLog stays referenced by:

Web (composition)
Agent (IAuditViewerService) and GoogleIntegration (ILegacyGoogleSyncAuditReader), whose contracts stay in the section
Calendar, Expenses, Store, Teams, Tickets and Users, whose views render <vc:audit-log> and need the assembly for @addTagHelper

Why

Most of the 37 sections referenced AuditLog only to write audit rows or declare actions (~100 lines with Base-only dependencies).

Existing surface checked

No new durable surface: existing public types change assembly, not shape. One XML cref to IAuditViewerService (which stays in the section) became <c>.

Checklist

Review tier: tier:standard (wide reference change, no behavior change).
~~No migration edited by hand~~: no migrations.
~~No NOT NULL column~~: no schema change.
Targeting main on peterdrier/Humans, branched off origin/main.

Docs: AuditLog.md (also drops the stale Humans.Gdpr reference left over from #2252, and Debug from the <vc:audit-log> consumer list since it only names the tag in text) and health.md; reference comments in seven csproj files.

Verification: dotnet build Humans.slnx -v quiet (0 errors) and dotnet test Humans.slnx -v quiet, no failures. Integration tests not run (opt-in).

Generated by Claude Code

IAuditLogService (with AuditLogEntrySnapshot) and AuditActionDefinition with its contributor contract move from Humans.AuditLog/Contracts to Humans.Base/AuditLog, namespace unchanged. Projects that only wrote audit rows or declared actions drop their AuditLog reference. AuditLog is still referenced by Web, Agent (viewer), GoogleIntegration (legacy reader) and the six sections whose views render <vc:audit-log>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA78CpJeYKoxRTGsySg

github-actions · 2026-11-02T23:09:48Z

Reviewed commit 9df7260. 1 inline finding(s) posted.

github-actions · 2026-11-02T23:13:21Z

PR Surface Report

Compared 3929aea0...3de6dd02. Scored with reforge 0.32.0.

Summary: 59 changed file(s) | EF migrations: 0 added file(s), max 0/1 per context

Reforge Surface Score

metric	base	head	delta
total	61544	61554	+10
surface	14394	14394	0

Section Deltas

section	base	head	delta
`Base`	3572	3652	+80
`AuditLog`	417	347	-70

Section Size & Complexity Deltas

section	LOC delta	files delta	classes delta
`AuditLog`	-88	-2	-3
`Base`	+88	+2	+3
Corpus	0	0	0

Corpus is the solution-wide rollup (same source as Corpus Size & Complexity below), not a sum of the section rows above - cognitive p95 in particular doesn't compose across sections.

Rule Deltas

rule	base	head	delta
`sectionSize`	7189	7199	+10

Published Write Surface

16 of 51 sections publish write capability, 51 interfaces (0).

Newly published

Base -> IAuditLogService

No longer published

AuditLog -> IAuditLogService

Interface Surface

No new interfaces or interface members.

Diff Size

bucket	added	deleted
code	9	41
tests	0	25
docs	12	10

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA78CpJeYKoxRTGsySg

peterdrier · 2026-11-03T11:06:37Z

@codex review

chatgpt-codex-connector · 2026-11-03T11:06:55Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-03T11:11:42.380598Z	`495e063`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Humans/src/Humans.Base/AuditLog/IAuditLogService.cs

Lines 21 to 22 in 495e063

    
           /// <summary>For a caller that needs rows as data (the issue thread). Pages use <c>&lt;vc:audit-log&gt;</c>.</summary> 
        
           Task<IReadOnlyList<AuditLogEntrySnapshot>> GetFilteredEntriesAsync(

Keep AuditLog query contracts out of Base

Moving these query methods and AuditLogEntrySnapshot with the append seam exposes AuditLog-owned reads and a section DTO through Base, which every section references. This creates a second public face for AuditLog and allows future consumers to query the section without declaring a dependency on its contract; move only the LogAsync seam to Base and leave the read methods/snapshot in AuditLog's Contracts surface.

AGENTS.md reference: AGENTS.md:L21-L23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA78CpJeYKoxRTGsySg

peterdrier · 2026-11-03T11:12:39Z

Re the Codex P1 (keep the AuditLog query methods out of Base): traced it. The two reads on IAuditLogService have four callers: GetFilteredEntriesAsync from Users (DuplicateAccountService), Issues (IssuesService) and Expenses (ExpenseReportService); GetEntityIdsForEntityTypeActionsAsync from Shifts (ShiftsController). Users and Expenses still reference AuditLog for <vc:audit-log>, so splitting the reads into a section-owned contract would put the reference back only on Issues and Shifts. It also means a new public interface, which is Peter's call. Asked him; leaving this PR as is until he decides.

Generated by Claude Code

#2253 moved IAuditLogService into Base whole, reads and AuditLogEntrySnapshot included. Base now holds only the two LogAsync overloads. Issues, Expenses and Users read through IAuditViewerService.GetFilteredAsync; Shifts' orphan scan reads GetEntityIdsForEntityTypeActionsAsync, now on the viewer. AuditLogEntrySnapshot is internal to the AuditLog section again. Issues and Shifts get their AuditLog reference back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA78CpJeYKoxRTGsySg

peterdrier self-assigned this Nov 2, 2026

github-actions Bot reviewed Nov 2, 2026

View reviewed changes

Comment thread src/Sections/Humans.Settings/Humans.Settings.csproj Resolved

Drop orphaned AuditLog reference comments in Settings

495e063

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA78CpJeYKoxRTGsySg

chatgpt-codex-connector Bot reviewed Nov 3, 2026

View reviewed changes

Comment thread src/Sections/Humans.AuditLog/Docs/AuditLog.md Resolved

Point AuditLog data-access map at the Base location

3de6dd0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA78CpJeYKoxRTGsySg

peterdrier merged commit 4599514 into main Nov 3, 2026
7 checks passed

peterdrier deleted the claude/project-thread-2c8v71 branch November 3, 2026 13:33

This was referenced Nov 3, 2026

Move the audit reads back out of Base onto IAuditViewerService #2259

Merged

Promote QA → production (26 commits) nobodies-collective/Humans#1263

Merged

peterdrier mentioned this pull request Nov 3, 2026

Move the Users core into Base; Base has no project references #2269

Merged

2 tasks done

Navigation Menu

Repository navigation

Move the audit append path into Base - #2253

Move the audit append path into Base#2253
peterdrier merged 3 commits into
mainfrom
claude/project-thread-2c8v71

peterdrier commented Nov 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

peterdrier commented Nov 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

peterdrier commented Nov 3, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// <summary>For a caller that needs rows as data (the issue thread). Pages use <c><vc:audit-log></c>.</summary>
	Task<IReadOnlyList<AuditLogEntrySnapshot>> GetFilteredEntriesAsync(

Conversation

peterdrier commented Nov 2, 2026

What

Why

Existing surface checked

Checklist

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Surface Report

Reforge Surface Score

Section Deltas

Section Size & Complexity Deltas

Rule Deltas

Published Write Surface

Interface Surface

Diff Size

Uh oh!

peterdrier commented Nov 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

peterdrier commented Nov 3, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Nov 2, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 3, 2026 •

edited

Loading