Repository navigation
doctor(Consent): every refused signature gets a message, and a recorded one never reads as failed - #2227
Conversation
Only Consent's Section.cs names SyncLegalDocumentsJob; its sibling job is already internal. Rule: memory/process/reuse-first-change-discipline.md (public surface needs a reason).
…ne never reads as failed A NotFound refusal showed nothing; a failed onboarding report after a recorded consent showed 'submit error'. Review gates on the same name check Submit refuses on, from the loaded user. Rule: memory/code/comments-earn-their-place.md (comments kept to the why).
IConsentWrite's summary said the caller audits; RecordConsentCheckAsync audits itself. Consent.md named the suspension as Consent's job (it is Users'), narrated removed navs three times and carried lane and dated labels. authorization.md now lists the policy Consent registers for Onboarding. Rule: memory/code/comments-earn-their-place.md.
Cost
API-equivalent $, list rates; run under subscription quota. Measured Phase 1 to PR creation; PR create/backfill and Phase 8 excluded. Peak main-thread context: 317,523 tokens (pr). Generated by Claude Code |
Section review1. Purpose, vision, intention
2. Public surfaceContracts interfaces
Public types
Routes
Shell contributions
Sections it depends on: Users, Teams, Governance, Notifications, Email, AuditLog, Gdpr, Onboarding (contracts only), HumanLifecycle (via Users). 3. Jobs
Both run half an hour before Users' suspension job. 4. Section debt
No 5. Questions
Generated by Claude Code |
|
@codex review Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed commit 9b5bace — no issues found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a04eff7614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR Surface ReportCompared Summary: 30 changed file(s) | EF migrations: 0 added file(s), max 0/1 per context Reforge Surface Score
Section Deltas
Section Size & Complexity Deltas
Rule Deltas
Corpus Size & Complexity
At head: largest class Published Write Surface17 of 51 sections publish write capability, 51 interfaces (-1). No longer published
Interface SurfaceNo new interfaces or interface members. Diff Size
New Files
|
…nger reports the signature as failed The decorator already evicted every alias before reloading; the reload error now logs instead of propagating to the controller's error flash. Codex round 1 on #2227.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA4NJZtkCuc6yysafYp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186neA4NJZtkCuc6yysafYp
Requested by Peter · project thread
What
Section-doctor re-run on Consent (unattended daily routine). Run file:
docs/health/runs/2026-10-31-Consent.md; target:src/Sections/Humans.Consent/Docs/health.md. Next up: Users, Preapprovals, Grants, Feedback.Why
Since its August run the section gained the Consent Coordinator's verdicts and the reminder stamp, and its target no longer described it. Reading it whole turned up two small bugs on the signing page.
/Consentwith no message; if the consent was recorded but the follow-up report to Onboarding threw, the member was told their signature failed. The Review page now gates on the same name check Submit refuses on, from the already-loaded user (one user read instead of two). Two new controller tests; reviewer-approved.SyncLegalDocumentsJobandILegalDocumentSyncRunnerare now internal (nothing outside Consent names them; the sibling reminder job already was). Reviewer-approved.health.mdrewritten with the member-review lane;IConsentWrite's summary no longer says the caller audits (the check write audits itself);Consent.mdno longer calls the suspension job Consent's, and drops removed-nav narration and dated labels;authorization.mdlists the policy Consent registers for Onboarding's queue; restating comments struck, mostly in tests.No live render happened (cloud run); the views did not change.
Existing surface checked
No new durable surface; two public types made internal.
Checklist
tier:standard.mainonpeterdrier/Humans, branched offorigin/main.dotnet test Humans.slnx -v quietgreen;dotnet format whitespace --verify-no-changesclean.Section labeled,NuGet,new project rule,nav coverage: not applicable (no new pages, packages or rules).Needs Peter
DocumentVersion.ConsentRecordsnavigation, proven by an empty migration?https://claude.ai/code/session_0186neA4NJZtkCuc6yysafYp
Generated by Claude Code