Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix publish CI #61

Merged
merged 4 commits into from
Nov 5, 2023
Merged

chore: fix publish CI #61

merged 4 commits into from
Nov 5, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Sep 25, 2023

Added

on:
  push:
    tags:
      - 'v[0-9]+.[0-9]+.[0-9]+*'

so that a tag like that can also trigger a release.

Additionally I added the check

- name: Compare version with ref/tag
  id: compare_version_with_tag
  run: |
    set -e
    TAG=${GITHUB_REF_NAME#v}
    if [[ "$VERSION" != "$TAG" ]]; then
      echo "Version in ${{ matrix.package }}/pubspec.yaml ($VERSION) does not match tag ($TAG)"
      echo "Skipping publish for ${{ matrix.package }}"
      echo "SHOULD_RUN=0" >> $GITHUB_ENV
    else
      echo "SHOULD_RUN=1" >> $GITHUB_ENV
    fi

@techouse
Copy link
Collaborator Author

techouse commented Nov 5, 2023

@petercinibulk can you please take a look at this once you get the time? :)

@petercinibulk petercinibulk merged commit b761441 into main Nov 5, 2023
techouse added a commit that referenced this pull request Nov 5, 2023
## 0.5.1

 - **FEAT**: add null value support (#61)
@techouse techouse mentioned this pull request Nov 5, 2023
@techouse techouse deleted the chore/fix-publish-ci branch November 5, 2023 13:09
petercinibulk pushed a commit that referenced this pull request Nov 5, 2023
## 0.5.1

 - **FEAT**: add null value support (#61)
@techouse techouse linked an issue Nov 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow
2 participants