-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove the dependency on bot_id in the task scheduling process #441
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
|
WalkthroughThis pull request refactors the task scheduling process by removing the dependency on Changes
|
@@ -48,7 +48,6 @@ def add_rag_git_doc_task(config: RAGGitDocConfig, extra=None): | |||
sha=sha, | |||
repo_name=config.repo_name, | |||
node_type=extra["node_type"], | |||
bot_id=config.bot_id, | |||
path=config.file_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that removing bot_id
does not affect any logic that relies on it. Double-check that all references to bot_id
are correctly handled or removed.
@@ -57,7 +57,6 @@ | |||
def get_task( | |||
task_type: TaskType, | |||
task_id: str, | |||
bot_id: Optional[str], | |||
) -> GitTask: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that the removal of bot_id
from get_task
function does not impact any dependent logic or functionality.
@@ -82,9 +86,9 @@ | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that the removal of bot_id
from trigger_task
function call does not affect any downstream processes that might require it.
release [email protected]