Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #63: invalid reads after write #64

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on May 6, 2021

  1. Configuration menu
    Copy the full SHA
    aa7c583 View commit details
    Browse the repository at this point in the history
  2. Implement fix for peterbourgon#63, read streams getting invalid data …

    …after write.
    
    This reworks the createKeyFileWithLock function (used only by
    writeStreamWithLock) so it always writes to a temporary file, which
    is renamed by writeStreamWithLock when complete. A deferred recover is
    added to clean up the temporary file if writing fails. This essentially
    deprecates the TempDir option by making all writes atomic.
    floren committed May 6, 2021
    Configuration menu
    Copy the full SHA
    ff85ff0 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Configuration menu
    Copy the full SHA
    7f654d3 View commit details
    Browse the repository at this point in the history
  2. Put the temporary files used for atomic writes into a subdirectory of…

    … BasePath.
    
    The key walking functions have been modified to ignore everything inside that directory, so getting a list of keys while a WriteStream is in progress will not include the temporary files.
    floren committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    823a6a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1bf728e View commit details
    Browse the repository at this point in the history
  4. remove extraneous if check

    floren committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    aceff81 View commit details
    Browse the repository at this point in the history