feat: support github server url for pushing to fork #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MildC Thank you for this contribution! Your fix looks good. I'm just going to merge it to a feature branch in this repository to fix the build before merging to Have you been able to test your feature branch and confirm that it works? It might be difficult for me to do that because I don't run self-hosted GitHub. |
|
@peter-evans Thanks for merging! I tested the new code on the feature branch and it can create the PR properly! |
|
@MildC Great. Thank you for confirming! |
peter-evans
added a commit
that referenced
this pull request
Nov 24, 2022
* feat: support github server url for pushing to fork (#1315) Co-authored-by: Kevin Zhu <[email protected]> * fix: code formatting * test: fix tests for getRemoteUrl Co-authored-by: MildC <[email protected]> Co-authored-by: Kevin Zhu <[email protected]>
|
Released as Thank you! |
aleksandrychev
pushed a commit
to aleksandrychev/create-pull-request
that referenced
this pull request
Mar 4, 2024
* feat: support github server url for pushing to fork (peter-evans#1315) Co-authored-by: Kevin Zhu <[email protected]> * fix: code formatting * test: fix tests for getRemoteUrl Co-authored-by: MildC <[email protected]> Co-authored-by: Kevin Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit added the support for alternative github server but the server url is still hard coded in
getRemoteUrlfunction. This breaks the pushing to fork workflow