-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of team-reviewers results in: "Could not resolve to a node with the global id of..." error #155
Comments
This looks like a permissions issue. Could you explain a bit more about your setup. Is the team in the same org as the repository? Does the team have collaborator (write) access to the repository? Is the repository private? |
Yes it is.
Yes the We have a Nested Team structure as follows:
Yes it is private. |
I'll try and find some time to reproduce the problem and see if I can find a workaround. I'm fairly sure this is not a problem with the action itself, it's likely to be a permissions related issue with the GitHub API. One thing you could try is using a PAT instead of the default |
I managed to setup an org and teams in the same way and reproduced the error. I'll see if I can figure out what the issue is and any workaround. |
So it seems to be permissions related, but I’m not sure if it's intentional. It might be a GitHub API bug. The problem seems to be that the default Here is how you can work around it:
|
Sorry for the delay in providing feedback. Using a PAT as a workaround works for us. Thank you very much for looking into the matter. |
@peter-evans - I am facing the same issue even if I use PAT token. Below fails Below works What am I doing wrong ? Could you Please help? |
Was able to reproduce the following error using a GitHub App for this endpoint - the issue is permissions.
For this endpoint to be successful the following permissions must be enabled on GitHub Apps:
|
I'm also facing the same issue with my new GitHub app, I have given the required permissions for the app, but still I'm getting this error. @loujr please let me know , if you are able to fix this issue? |
``` Error: Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the readthedocs/sphinx-hoverxref repository. ``` It seems it's a permission issue. See peter-evans/create-pull-request#155 (comment) However, we are not having this issue in .org. I'm removing the reviewers for now just to move forward because we haven't updated the requirements in a while now.
This updates the action from v4 to v5 and replaces the use of `team-reviewers` with `reviewers`. Background: - peter-evans/create-pull-request#1638 - peter-evans/create-pull-request#155
if that helps anyone, make sure as a itemId you do not use the itemId you see in github webapp url, but rather its true node ID starting with |
Subject of the issue
Providing a GitHub team to request a review from doesn't work.
Steps to reproduce
In the example above,
developers
is a valid Github team. When I base64 decodeMDQ6VGVhbTE3NTI3NjE=
in the error below, it resolves to:04:Team1752761
and I can confirm that1752761
is the correct id for ourdevelopers
Github team.The error message we see is:
The text was updated successfully, but these errors were encountered: