Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"offline" mode? #37

Closed
glenjamin opened this issue Jan 11, 2016 · 3 comments
Closed

"offline" mode? #37

glenjamin opened this issue Jan 11, 2016 · 3 comments

Comments

@glenjamin
Copy link
Contributor

I quite often work on a train with poor internet connections - usually making small changes to something that mostly already works.

This plugin always attempts to validate the puppet version against the rubygems API - which requires quite a lot of data transfer over the network.

Would you be open to providing a way to disable this check? Perhaps skipping it entirely if the puppet version is already fully qualified?
@petems
Copy link
Owner

petems commented Jan 11, 2016

Yep, this should be configurable. Just an option to disable the version validation check.

petems added a commit that referenced this issue Apr 2, 2016
@petems
Adds option to disable config validation
2d04e67 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
@petems petems mentioned this issue Apr 2, 2016
Merged
petems added a commit that referenced this issue Apr 2, 2016
@petems
Adds option to disable config validation
f253b89 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
petems added a commit that referenced this issue Apr 2, 2016
@petems
Adds option to disable config validation
71020d6 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
petems added a commit that referenced this issue Apr 4, 2016
@petems
Adds option to disable config validation
8a72b91 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
petems added a commit that referenced this issue Apr 23, 2016
@petems
Adds option to disable config validation
6db2f3f 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
petems added a commit that referenced this issue Apr 23, 2016
@petems
Adds option to disable config validation
d2178fe 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
petems added a commit that referenced this issue Apr 23, 2016
@petems
Adds option to disable config validation
edf65ce 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
petems added a commit that referenced this issue Apr 23, 2016
@petems
Adds option to disable config validation (#46)
32dba57 
* New config option `validate_version` which can be set to false to stop validation with RubyGems API
* Closes #37
@glenjamin
Copy link
Contributor Author

Awesome, thanks!

@petems
Copy link
Owner

petems commented Apr 23, 2016

This is now released in version 4.1.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glenjamin @petems