Skip to content

Cleanup all async operation during shutdown#249

Merged
Aaronontheweb merged 2 commits intopetabridge:devfrom
Arkatufus:async_cleanup
Sep 23, 2022
Merged

Cleanup all async operation during shutdown#249
Aaronontheweb merged 2 commits intopetabridge:devfrom
Arkatufus:async_cleanup

Conversation

@Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Sep 22, 2022

Possible solution for #248

Changes

  • Cleanup async calls by wrapping all async calls with shutdown CancellationTokenSource that gets cancelled and disposed on PostStop() callback

## Changes
- Cleanup async calls by wrapping all async calls with shutdown CTS that gets cancelled and disposed on PostStop
@Arkatufus Arkatufus closed this Sep 22, 2022
@Arkatufus Arkatufus reopened this Sep 22, 2022
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit c22a034 into petabridge:dev Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments