Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests not matching any objects are not considered risky #3

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

gehrisandro
Copy link

Starting from v2.2.3 Arch tests not matching any object are considered as successful instead of risky.

Given the following test:

test('global')
    ->expect('Invalid\Namespace')
    ->toUseStrictTypes();

v2.2.3 returns the following output:

Screenshot 2023-08-03 at 20 38 47

v2.2.2 and before the test has been considered as risky:

Screenshot 2023-08-03 at 20 38 39

This behaviour has changed here: f44834b

From the commit message I can't figure out what the reason behind this change was. But I hope my PR does not mess up with it.

@nunomaduro Maybe you help me out here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant