Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest Insiders uses nodejs 16 and may have broken extension #106

Closed
JustinGrote opened this issue Mar 12, 2022 · 2 comments
Closed

Latest Insiders uses nodejs 16 and may have broken extension #106

JustinGrote opened this issue Mar 12, 2022 · 2 comments

Comments

@JustinGrote
Copy link
Collaborator

I think they finally moved to nodejs 16 and the streams interface I was using changed:
image
@JustinGrote JustinGrote changed the title Latest Insiders may have broken extension Latest Insiders uses nodejs 16 and may have broken extension Mar 12, 2022
@JustinGrote JustinGrote mentioned this issue Mar 13, 2022
Closed
@JustinGrote
Copy link
Collaborator Author

Upstream: microsoft/vscode#144962

@JustinGrote
Copy link
Collaborator Author

Fixed in bd55931 using the generic pipeline argument rather than arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JustinGrote