Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insiders VSCode on Node 16.10 breaks pipeline streams #144962

Closed
JustinGrote opened this issue Mar 12, 2022 · 2 comments · Fixed by #145527
Closed

Insiders VSCode on Node 16.10 breaks pipeline streams #144962

JustinGrote opened this issue Mar 12, 2022 · 2 comments · Fixed by #145527
Assignees
Labels
electron-17-update Issues related to electron 17 update extension-host Extension host issues fixed-in-electron-18 Issues fixed with Electron 18.x update insiders-released Patch has been released in VS Code Insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@JustinGrote
Copy link
Contributor

Issue Type: Bug

My Pester Tests extension uses this API. The latest insiders which switched to NodeJS 16.x broke my extension. Here is the relevant issue that is fixed in later versions, if possible to bump vscode to a newer vscode 16.x version
nodejs/node#40191

// Workaround nodejs/node#40191
// todo: remove it when fix is released in 16.x and in AppEngine 16.x
if (process.version > 'v16.13') {
const { pipeline } = require('stream/promises')
_pipeline = ((streams: AnyStream[]) => pipeline(...streams)) as any
}

VS Code version: Code - Insiders 1.66.0-insider (6b74534, 2022-03-11T05:17:19.559Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info
Item Value
CPUs AMD Ryzen 7 4700U with Radeon Graphics (8 x 1996)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.36GB (2.59GB free)
Process Argv --crash-reporter-id 4453efaa-0821-4555-88e2-3de8bad9109e
Screen Reader no
VM 0%
Extensions (40)
Extension Author (truncated) Version
vscode-color ans 0.4.5
vscode-opennewinstance chr 0.0.12
esbuild-problem-matchers con 0.0.2
vscode-github-actions csc 0.22.0
vscode-eslint dba 2.2.2
vscode-generate-getter-setter DSK 0.5.0
gitlens eam 12.0.4
filter-lines ear 1.0.0
EditorConfig Edi 0.16.4
prettier-vscode esb 9.3.0
lintlens ghm 3.0.2
copilot-nightly Git 1.7.5297
remotehub Git 0.26.0
vscode-pull-request-github Git 0.38.1
todo-tree Gru 0.0.215
vscode-drawio hed 1.6.4
change-case hjd 1.0.2
vscode-peacock joh 4.0.0
git-graph mhu 1.30.0
vscode-html-format moh 0.0.4
vscode-docker ms- 1.20.0
csharp ms- 1.24.1
remote-containers ms- 0.226.0
remote-ssh ms- 0.77.2022031115
remote-ssh-edit ms- 0.77.2022031115
js-debug-nightly ms- 2022.3.717
powershell-preview ms- 2022.3.0
indent-rainbow ode 8.2.2
docthis oou 0.8.2
vscode-jest Ort 4.2.1
pester-test psp 2022.2.0
vscode-commons red 0.0.6
vscode-yaml red 1.5.1
vscode-sort-json ric 1.20.0
vscode-inline-values-powershell Tyl 0.0.5
errorlens use 3.4.2
vscode-icons vsc 11.10.0
codetour vsl 0.0.58
gitmoji-vscode Vtr 1.0.9
better-align wwm 1.1.6
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstarted:30449409
vsclayoutctrc:30405799
dsvsc009:30440021
pythonvsnew555:30438690
vscscmwlcmt:30428973
vscgsvid2:30433758
dockersurvey3:30438168
pynewfile477:30451556

@yume-chan
Copy link
Contributor

It's fixed in Node.js 16.13.1

[36d3b123a0] - stream: support array of streams in promises pipeline (Mestery) nodejs/node#40193

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md#2021-12-01-version-16131-gallium-lts-bethgriggs

It will require Electron 18

Updated Node.js to v16.13.2. #32418

https://www.electronjs.org/releases/alpha#18.0.0-alpha.1

It will take a long time before Electron 18 hit stable and Code upgrade to it. So maybe you should try the workaround.

@JustinGrote
Copy link
Contributor Author

Another workaround is to use the generic pipeline method overload rather than the array-based one.

@deepak1556 deepak1556 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream electron-17-update Issues related to electron 17 update fixed-in-electron-18 Issues fixed with Electron 18.x update extension-host Extension host issues labels Mar 17, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 10, 2022
@vscodenpa vscodenpa added this to the June 2022 milestone Jun 10, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron-17-update Issues related to electron 17 update extension-host Extension host issues fixed-in-electron-18 Issues fixed with Electron 18.x update insiders-released Patch has been released in VS Code Insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@deepak1556 @yume-chan @JacksonKearl @JustinGrote @vscodenpa and others