Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose the unicode emoji builtin rules #874

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jun 21, 2023

ref: #872

@tomtau tomtau requested a review from a team as a code owner June 21, 2023 08:00
@tomtau tomtau requested review from NoahTheDuke and removed request for a team June 21, 2023 08:00
@huacnlee
Copy link
Member

EMOJI, EMOJI_COMPONENT, EMOJI_MODIFIER, EMOJI_MODIFIER_BASE, EMOJI_PRESENTATION, EXTENDED_PICTOGRAPHIC where are you get this code?

In Pest, there have a script (update_unicode.sh) to generate the Unicode names.

@tomtau
Copy link
Contributor Author

tomtau commented Jun 21, 2023

EMOJI, EMOJI_COMPONENT, EMOJI_MODIFIER, EMOJI_MODIFIER_BASE, EMOJI_PRESENTATION, EXTENDED_PICTOGRAPHIC where are you get this code?

In Pest, there have a script (update_unicode.sh) to generate the Unicode names.

from here: https://pest.rs/book/grammars/built-ins.html#binary-properties

@huacnlee
Copy link
Member

Oh, never mind on my last comment.
You do the right way. The Emoji unicode script has been generated before, we just not publish in pest mod.rs

@tomtau tomtau merged commit 047c27e into pest-parser:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants