-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Span::get
#681
Implement Span::get
#681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may still fail in no_std... if you'd like to test no_std, you can try to build it as follows: rustup run nightly -- cargo build -j1 -Z build-std=core,alloc --target x86_64-unknown-linux-gnu
I have never been in a no std environment before. Actually in general this is my first Rust OSS participation. I couldn't get your suggestion to work but https://lib.rs/crates/cargo-no-std-check seemed to do the trick to test the build for no_std. |
Thank you and congratulations on your first Rust OSS participation! 🎉 |
Partially revives #456 and merge would partially close #455.
This implementation changes the name of the new feature in #456 from
Span::sub_span
toSpan::get
to have parity withstr::get
.This implementation does not require
std
.