Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate #560

Merged
merged 9 commits into from
Oct 2, 2020
Merged

Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate #560

merged 9 commits into from
Oct 2, 2020

Conversation

shimono
Copy link
Member

@shimono shimono commented Mar 5, 2020

This is for 1.7.22 release.

@shimono shimono added this to the 1.7.22 milestone Mar 5, 2020
@shimono shimono self-assigned this Mar 5, 2020
@shimono shimono requested a review from tochi-y March 5, 2020 10:00
@shimono shimono linked an issue Mar 9, 2020 that may be closed by this pull request
Should respond error when accessed via domain name different from the one configured in Unit Certificate #535
Closed
@shimono shimono changed the title Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate (Based on PR557) Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate Mar 12, 2020
@shimono shimono changed the title (Based on PR557) Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate Mar 12, 2020
tochi-y
tochi-y requested changes Sep 18, 2020
View reviewed changes
Copy link
Member

@tochi-y tochi-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

src/main/java/io/personium/core/PersoniumCoreException.java Show resolved Hide resolved
src/main/java/io/personium/core/rs/FacadeResource.java Outdated Show resolved Hide resolved
src/main/java/io/personium/core/rs/FacadeResource.java Outdated Show resolved Hide resolved
src/test/java/io/personium/core/rs/FacadeResourceTest.java Outdated Show resolved Hide resolved
tochi-y
tochi-y approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tochi-y tochi-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tochi-y tochi-y merged commit f4250d0 into personium:develop Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tochi-y tochi-y tochi-y approved these changes

Assignees

@shimono shimono

Labels
enhancement
Projects
None yet
Milestone
1.7.22
Development

Successfully merging this pull request may close these issues.

Should respond error when accessed via domain name different from the one configured in Unit Certificate
2 participants
@shimono @tochi-y