-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure ada_feeding
for Articulable Fork
#211
Open
jjaime2
wants to merge
26
commits into
ros2-devel
Choose a base branch
from
jjaime2/articulable_fork_feeding_v2
base: ros2-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sociated with the selected end_effector_tool, and use it when defining the list of joint_names in the MoveIt2 object
… Articulable Fork
…as a parameter to ada_feeding_action_servers
…nfigurations based on tool_joints associated with end_effector_tool
…sed on tool_joints defined by end_effector_tool
jjaime2
changed the title
Configure
Configure Jan 13, 2025
ada_feeding
with end_effector_tool
ada_feeding
for Articulable Fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request modularizes the entire
ada_feeding
stack to dynamically load the robot description, defines controllers and move groups, and updates static configurations for a specifiedend_effector_tool
. When launching theada_feeding
software stack, setting theend_effector_tool
to eitherfork
orarticulable_fork
will require that the necessary hardware be assembled and connected, but will otherwise be able to complete the end-to-end feeding task in the same manner.A prerequisite to testing these changes is having your development machine setup according to the Software Installation section of the Articulable Fork Assembly Guide
Related PRs: personalrobotics/ada_ros2#52, personalrobotics/ada_ros2#53, personalrobotics/ada_ros2#54
To test on the real hardware, first connect the appropriate hardware to your development machine via USB, e.g. for
end_effector_tool = fork
only connect the Jaco to your machine, and forend_effector_tool = articulable_fork
connect both the Jaco and Articulable Fork to your machineTesting procedure
python3 src/ada_feeding/start.py --sim <real / mock> --end_effector_tool <tool>
for each<tool>
infork
,articulable_fork
.RViz2
, observe that the appropriate robot description has been loaded visuallyMotionPlanning
window inRViz2
, open thePlanningGroup
drop-down menu and observe that the available options areada
,articulable_fork
,hand
, andjaco_arm
. Set thePlanningGroup
tohand
for now, and toggleDisplays -> MotionPlanning
on/off to avoid visual glitches inRViz2
.Start Feeding
to move ADA into theAbovePlate
configurationMove to mouth
button, and observe ADA's motion as it orients the fork towards the front of the user's faceContinue
and observe ADA move the fork towards the user's mouth, but stop after achieving a set distanceMove above plate
and observe ADA move the fork away from the user's mouth, and move into theAbovePlate
configurationDone eating
and observe ADA moving into theStow
configurationBefore opening a pull request
pre-commit run --all-files
pylint --recursive=y --rcfile=.pylintrc .
. All warnings butfixme
must be addressed.Before Merging
Squash & Merge