-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Labeling #203
base: ros2-devel
Are you sure you want to change the base?
Semantic Labeling #203
Changes from all commits
8ed6683
dcb74b7
c611e78
4fb0258
5d81216
bfcaeaa
19e9275
c29520d
4e7391f
9c43fc4
31551e4
3ec7b50
9dc9a40
929e570
e1ebf8b
704caa1
4f9305d
024c71c
c78cd4a
e503800
648a46e
3032f65
85f9577
0049598
e9fd4d5
9d52d98
30bc036
4d3b27c
94af48e
29ed345
23577ae
3688541
195b123
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,9 @@ | |
build/ | ||
__pycache__/ | ||
|
||
# Environment Variables file | ||
.env | ||
|
||
# Compiled Object files | ||
*.slo | ||
*.lo | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -336,7 +336,7 @@ def update(self) -> py_trees.common.Status: | |
x_unit.vector, x_pos.vector | ||
) | ||
|
||
# # If you need to send a fixed food frame to the robot arm, e.g., to | ||
# # If you need to send a fixed food frame to the robot arm, e.g., to | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unintended? |
||
# # debug off-centering issues, uncomment this and modify the translation. | ||
# deg = 90 # fork roll | ||
# world_to_food_transform.transform.translation.x = 0.26262263022586224 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
# The interface for an action that gets an image from the camera and returns | ||
# the masks of all segmented items within that image. | ||
|
||
# The list of input semantic labels for the food items on the plate | ||
string caption | ||
Comment on lines
+4
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment seems misleading, I suspect this was an old comment for |
||
--- | ||
# Possible return statuses | ||
uint8 STATUS_SUCCEEDED=0 | ||
|
@@ -17,6 +19,9 @@ std_msgs/Header header | |
sensor_msgs/CameraInfo camera_info | ||
# Masks of all the detected items in the image | ||
ada_feeding_msgs/Mask[] detected_items | ||
# A list of semantic labels corresponding to each of the masks of detected | ||
# items in the image | ||
string[] item_labels | ||
--- | ||
# How much time the action has spent segmenting the food item | ||
builtin_interfaces/Duration elapsed_time |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# The interface for a service that takes in a list of input labels | ||
# describing the food items on a plate and returns a sentence caption compiling | ||
# these labels used as a query for GroundingDINO detection. | ||
|
||
# A list of semantic labels corresponding to each of the masks of detected | ||
# items in the image | ||
string[] input_labels | ||
--- | ||
# A sentence caption compiling the semantic labels used as a query for | ||
# GroundingDINO to perform bounding box detections. | ||
string caption | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: add newlines at the end of files. (I know not all files have it, but in general it is a best practice so we should enforce it on new/modified files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a
.env
file added in this PR, but I'm guessing this was more for personal use. I'd recommend omitting this change unless it's relevant for the functionality of the PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed more references to a
env
file later in the code, where exactly does this come into play?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding environment variable functionality to our codebase so we can privately store API keys without exposing them publicly in github. In this particular case, it is for accessing the PRL OpenAI API key to invoke GPT-4o.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this may come in handy later on as well if we power perception w/ foundation models in the future.