File downloaded with `_1` at the end of the name

[hueychen27]

When downloading files, Persepolis will append _1 right before the extension name to the file. For example, downloading file.zip will result in a file_1.zip file being created.

[alireza-amirsamimi]

Perhaps you have a file that has not finished downloading or has finished downloading in the Persepolis download folder or its subfolders.

[hueychen27]

No, it always happens when the file is finished downloading. In fact, the rename dialog adds the "_1" to it but does not let me change it.

[hueychen27]

Also, this used to not happen some time ago. I do not remember when, but it was probably a few months ago that this bug occurs.

[hueychen27]

I realize this is because the Persepolis Browser Integrator is not intercepting the downloads even when enabled, so the browser already downloads the file.

[eajaykumar]

i fixed it , it has to do with quotes python using to name

def downloadCompleteAction(self, new_download_path):
    # rename file if file already existed
        self.file_name = self.file_name.strip('"').strip("'")
        print("[DEBUG] Raw filename from link or header:", repr(self.file_name))
     
        temp_folder = os.path.dirname(self.file_path)
        base_name = os.path.basename(self.file_path)
        base_name_no_ext, ext = os.path.splitext(base_name)

        print("[DEBUG] Scanning aria2 temp folder...")
        print("[DEBUG] Contents of aria2 temp folder:", os.listdir(temp_folder))
        print("[DEBUG] Expected file basename:", base_name)
        print("[DEBUG] Expected cleaned pattern:", re.sub(r'[^a-zA-Z0-9]', '', base_name_no_ext.lower()))

        found_real_file = False
        for f in os.listdir(temp_folder):
            normalized_f = re.sub(r'[^a-zA-Z0-9]', '', f.lower())
            normalized_expected = re.sub(r'[^a-zA-Z0-9]', '', base_name_no_ext.lower())

            if normalized_expected in normalized_f and (f.endswith(ext) or f.endswith(ext + '.part')):
                real_path = os.path.join(temp_folder, f)
                print("[DEBUG] Found actual downloaded file:", repr(real_path))
                self.file_path = real_path
                found_real_file = True
                break

        if not found_real_file:
            print("[DEBUG] Warning: Could not find actual downloaded file in aria2 temp folder.")

        base_name, ext = os.path.splitext(self.file_name)
    
        i = 0
        while True:
            suffix = f"_{i}" if i > 0 else ""
            candidate_name = f"{base_name}{suffix}{ext}"
            candidate_path = os.path.join(new_download_path, candidate_name)

            if not os.path.exists(candidate_path):
                break
            i += 1

        print(f"[INFO] File saved to: {candidate_path}")

        try:
            shutil.move(self.file_path, candidate_path)
            print(f"[DEBUG] Final resolved target path: {candidate_path}")
            return candidate_path
        except FileNotFoundError:
            print(f"[ERROR] Source file not found: {self.file_path}")
            return None

        # Move the file to final location with the safe unique name
       
        print("[DEBUG] Final resolved target path:", repr(new_file_path))
        print("[DEBUG] Source file path:", self.file_path)
        print("[DEBUG] File exists at source?", os.path.exists(self.file_path))

        free_space = freeSpace(new_download_path)

        if free_space is not None and self.file_size is not None:
            if free_space >= self.file_size:
                move_answer = moveFile(str(self.file_path), str(new_file_path), 'file')
                print("[DEBUG] Move result:", move_answer)
                if not move_answer:
                    logger.sendToLog('Persepolis can not move file - GID: ' + self.gid, "ERROR")
                    new_file_path = self.file_path
            else:
                new_file_path = self.file_path
                logger.sendToLog('Insufficient disk space in download folder - GID: ' + self.gid, "ERROR")
                notifySend("Insufficient disk space!", 'Please change download folder', 10000, 'fail', parent=self.main_window)
        else:
            move_answer = moveFile(str(self.file_path), str(new_file_path), 'file')
            print("[DEBUG] Move result (no space check):", move_answer)
            if not move_answer:
                logger.sendToLog('Persepolis can not move file - GID: ' + self.gid, "ERROR")
                new_file_path = self.file_path

        print("[DEBUG] Final download path:", new_file_path)
        return str(new_file_path)

it will fix all issues including quotes and also when we have duplicate files in folders it will keep on incrementing file with _1 ,_2 ....etc

[eajaykumar]

just do import

import re
import shutil

[eajaykumar]

i checked with all scenario downloading same file again and again and deleting files in download folders to check and its working fine with incrementing duplicate files so no overriding existing files in download folders

[alireza-amirsamimi]

i checked with all scenario downloading same file again and again and deleting files in download folders to check and its working fine with incrementing duplicate files so no overriding existing files in download folders

Thank you🙏. Why don't you send pull request?

[eajaykumar]

actually i stopped coding for a long time ,so i don't want to
there's a conflict in aria2 temporary folder , it took me 24 hours figuring out whats the problem ,i did so many debugging sessions to find out root cause
so you should delete all things in .config folder and start a fresh installation
you can test and report me

[alireza-amirsamimi]

actually i stopped coding for a long time ,so i don't want to
there's a conflict in aria2 temporary folder , it took me 24 hours figuring out whats the problem ,i did so many debugging sessions to find out root cause
so you should delete all things in .config folder and start a fresh installation
you can test and report me

My suggestion is that you send the pull request. However, if for any reason you don't want to do that, I will test your code tonight and push it to the repository.🙏

[eajaykumar]

am searching for job so i don't want to do, am just studying now

[hueychen27]

This is incredible! I disabled Persepolis for a long time because of this issue.

[eajaykumar]

you can also close this "no file name #973" same issue