chore: 🔧 update postinstall script #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perry-mitchell
requested changes
Oct 11, 2023
CHANGELOG.md
Outdated
| ## v2.2.1 | ||
| _2023-10-10_ | ||
| * [#33](https://github.com/perry-mitchell/ulidx/pull/33): Use prepare instead of postinstall for git hooks | ||
|
|
There was a problem hiding this comment.
No need for version bump, that's part of my release process :)
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ulidx", | |||
| "version": "2.2.0", | |||
| "version": "2.2.1", | |||
|
Thanks for this! I'll get it released in a moment. |
perry-mitchell
approved these changes
Oct 11, 2023
|
Released under 2.2.1. Thanks for spotting and sorry for the inconvenience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Renovate updated ulidx to 2.2.0 and our pipeline failed. I believed the issue is using the
postinstallscript to setup git hooks instead ofprepare, which runs afternpm install.Because
postinstallwill run when a dependency installs their packages, whilepreparewill only ever run locally, not for dependencies of ulidx.Might close #32