Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setindex(::Tuple, _, ::StaticInteger) inferrable #6

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Jan 11, 2020

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #6 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   78.59%   78.74%   +0.14%     
==========================================
  Files           6        6              
  Lines         285      287       +2     
==========================================
+ Hits          224      226       +2     
  Misses         61       61
Impacted Files Coverage Δ
src/StaticNumbers.jl 88.31% <100%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e4c08...749e544. Read the comment docs.

@perrutquist perrutquist merged commit c7f2a85 into perrutquist:master Jan 11, 2020
@perrutquist
Copy link
Owner

Thanks!

@tkf
Copy link
Contributor Author

tkf commented Jan 13, 2020

Thanks for merging this!

It's not urgent, it'd be great if this can be released soon-ish. We are waiting for the release in jw3126/Setfield.jl#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setindex(::Tuple, _, ::StaticInteger) is not fully inferred
2 participants