Skip to content

fix(cu): only use readState body on nonce match #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(cu): only use readState body on nonce match #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions servers/cu/src/effects/hb/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const resToJson = (res) => {
const toParams = ({ processId, from, to, pageSize }) =>
new URLSearchParams(filter(
isNotNil,
{ target: processId, 'from': from, 'to': to, limit: pageSize, accept: 'application/aos-2' }
{ target: processId, from, to, limit: pageSize, accept: 'application/aos-2' }
))

const nodeAt = (idx) => pipe(path(['edges']), nth(idx), path(['node']))
Expand Down Expand Up @@ -266,7 +266,7 @@ export const loadMessagesWith = ({ hashChain, fetch, logger: _logger, pageSize }

return Promise.allSettled(
args.map(({ suUrl, processId, from, to, pageSize }) => {
return Promise.resolve({ processId, from: from ? from : 0, to: to ? to : undefined, pageSize })
return Promise.resolve({ processId, from: from || 0, to: to || undefined, pageSize })
.then(toParams)
.then((params) => fetch(`${suUrl}/[email protected]/schedule?${params.toString()}`))
.then(okRes)
Expand Down Expand Up @@ -322,7 +322,7 @@ export const loadMessagesWith = ({ hashChain, fetch, logger: _logger, pageSize }

return backoff(
() => {
if(body) {
if (body && body.edges.length === (+to - +from) && body.edges[0]?.node?.assignment?.Tags?.find(t => t.name === 'Nonce')?.value === from) {
return body
}
return fetchPageDataloader.load({ suUrl, processId, from, to, pageSize })
Expand All @@ -340,7 +340,7 @@ export const loadMessagesWith = ({ hashChain, fetch, logger: _logger, pageSize }
* and coerce to false, and otherwise cast to a boolean.
*/
function toBoolean (value) {
return value === 'false' ? false : Boolean(value)
return (value === 'false' || value === 'undefined') ? false : Boolean(value)
}

return async function * scheduled () {
Expand Down Expand Up @@ -402,7 +402,7 @@ export const loadMessagesWith = ({ hashChain, fetch, logger: _logger, pageSize }
let prevAssignmentId = assignmentId
let prevHashChain = hashChain

//let expectedNonce = parseInt(`${from}`)
// let expectedNonce = parseInt(`${from}`)
let expectedNonce = isColdStart ? 0 : parseInt(`${from}`) + 1
return async function * (edges) {
for await (const edge of edges) {
Expand Down Expand Up @@ -481,7 +481,7 @@ export const loadMessageMetaWith = ({ fetch, logger }) => {

return backoff(
() => {
if(body) {
if (body && body.edges.length === 1 && body.edges[0]?.node?.message?.id === messageUid) {
return body
}
return fetch(`${suUrl}/[email protected]/schedule?${params.toString()}`).then(okRes)
Expand Down