fix: detect and encode eth address correctly #401
+80
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twilson63
reviewed
Aug 6, 2025
twilson63
reviewed
Aug 7, 2025
twilson63
left a comment
twilson63
left a comment
There was a problem hiding this comment.
- 3 failing tests
- Code Review Looks good
- I would recommend adding a unit test that provides a ECDSA public key and uses to_address and confirm it returns the correct Etherium Address
- BONUS - would be to add a test that sends a ECDSA signed message to a process and confirms the process received a message with the Eth Address as Owner
- No issues from security or performance perspective
twilson63
approved these changes
Aug 8, 2025
twilson63
left a comment
twilson63
left a comment
There was a problem hiding this comment.
- All tests pass
- Tests look good
- Syntax looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where if the owner of a message is an ETH address it gets parsed as an AR address. We now detect the length of the address and correctly parse it to an ETH address.
cc @samuelmanzanera