-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hosted files and rules to ids/
directory.
#3264
base: master
Are you sure you want to change the base?
Conversation
- The number of files and directories is too large for the GitHub web interface to display. - It's difficult to find basic info on the GitHub project page with so many files. - Hosted and non-hosted files were mixed together.
Maybe you did that, or it makes no sense in this case, but I though I mention this idea: |
@hoijui I'm not sure I understand. How would a script help here? I think writing a correct script and instructing people to use it may be more difficult then using git itself to do the updates. I think the git part will be challenge enough. A script also won't help the many people who, I think, are only using the github UI to make changes. |
This has been open for a significant amount of time with little feedback. At some point this PR will be updated and applied if no one objects. |
The script helps primarily people like you, who might maintain different branches, or who would apply the script to branches by others, which branched off before this change, and which we want to merge back after this change. Hope you get this change through soon! :-) |
Great initiative and I support this. Thanks for the work. I guess we also need an advanced announcement as well that we are going to freeze the repo for few days in order to make this change (and avoid merge conflicts).
|
There's really nowhere to make announcements with this service. This ids/ update is not a days long process. I think I only spent no more than 30 minutes on this PR. Fixing it or doing it again will be quick. Updating the live servers the easy way will mean a minute or two of downtime to adjust some things. Could make that almost zero downtime but that's more effort than it's worth. Then the few open PRs here will likely need fixing. We'll have to watch new PRs to make sure they use the new pattern, but if old style ones are merged, they won't work, so that should resolve itself quickly. |
DO NOT MERGE
Closes: #2709