Changed to use from_utf8_lossy again #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason I changed to this before was that I couldn't get it working with the `Cow` object. Today, I checked the problem again and found the solution: `into_owned`, which takes ownership of the borrowed data (by copying it). Wonderful! Also fixed a linting issue I happened to see when reading the Travis output.
perlun
force-pushed
the
fix/get-rid-of-unsafe-code
branch
from
e4c28e5 to
26091fe
Compare
|
You don't really expect me to review on a saturday, so I guess the 8 minute review time could be acceptable in this case. 😝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I changed to this before was that I couldn't get it working with the
Cowobject. Today, I checked the problem again and found the solution:into_owned, which takes ownership of the borrowed data (by copying it). Wonderful!