Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

$INC{strict.pm} => PVNV #110

Closed
rurban opened this issue Mar 9, 2016 · 1 comment
Closed

$INC{strict.pm} => PVNV #110

rurban opened this issue Mar 9, 2016 · 1 comment
Assignees

Comments

@rurban
Copy link
Member

rurban commented Mar 9, 2016

xs_incset uses a newSVpv_share(FILE, 0) as %INC value, which is first a proper PV, but then somehow gets turned into a PVNV without POK flag, which would explain the prereq failures in the toolchain. Easily seen with B::C, any test, for strict.pm, coretypes.pm and the 2 XSLoader.pm and DynaLoader.pm keys.

%INC is a HvSHAREKEYS, means its keys are shared in PL_strtab, and the HE is a shared_he

@rurban rurban self-assigned this Mar 9, 2016
@rurban
Copy link
Member Author

rurban commented Mar 10, 2016

Fixed by removing the line
$INC{"strict.pm"}++ in B::C, which uncow'ed the value, and converted it to a PVNV.
See 5032167b7d80517404f4c7d03ec612dc50f61972

@rurban rurban closed this as completed Mar 10, 2016
rurban pushed a commit that referenced this issue Mar 18, 2016
$INC{strict.pm}++ removed the string value
rurban added a commit that referenced this issue Aug 27, 2018
4.06 2018-08-22 (rurban)
        - Fix overloaded eq/ne comparisons (GH #116 by demerphq, GH #117 by Graham Knopp):
          detect strings, protect from endless recursion. false is now ne "True".
          clarify eq/ne rules in the docs.

4.05 2018-08-19 (rurban)
        - Set decoded type (PR #115 by Pali)
        - Add json_type_weaken (PR #114 by Pali)
        - Fix tests for 5.6 (rurban, pali)

4.04 2018-06-22 (rurban)
        - Fix bignum NaN/inf handling (#78 reported by Slaven Rezic)
        - Move author tests to xt/ as suggested in #106, added a make xtest target.
          Fixes a test fail with ASAN.

4.03 2018-06-21 (rurban)
        - Add sereal cpanel_json_xs type (#110 James Rouzier)
        - Fix bencode/bdecode methods in cpanel_json_xs (#111 Fulvio Scapin)
        - Overload ne operator for JSON::PP::Boolean (#107 tevfik1903)
        - Add a missing semicolon to a documentation example (#104 E. Choroba)

4.02 2018-02-27 (rurban)
        - Add encoder indent_length method (#103 rouzier), previously
          hard-coded to 3.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant