Don't call each on an anonymous hash in Pod::Simple::HTMLBatch #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From perldiag:
each on anonymous %s will always start from the beginning
(W syntax) You called each on an anonymous hash or array. Since a
new hash or array is created each time, each() will restart iterating
over your hash or array every time.
Bug: perl-pod#190
Bug-Debian: https://bugs.debian.org/1114492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Karl, here's a trivial fix for #190. No idea if anybody really uses the code path, but at least this shouldn't make things worse.
Thanks for all the work you do on Perl!
Niko