bcm283x: gpio: add bcm2711 specific alt funcs mapping #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BCM2711 provides more alternate pin functions than the BCM283x. An extra mapping table mapping2711 is added by this change, which gets assigned to the `mapping` variable conditionally during driverGPIO.Init(). The existing mapping is renamed to mapping283x, and used as default to keep tests working. This change enables selecting alternate functions at runtime on a BCM2711 that were not supported by the existing BCM283x specific mapping, like GPIO4's UART3_TX; toggling between UART_TX and IN at runtime can be useful e.g. when sharing a single CAN transceiver between a CAN controller and a UART peripheral. Resolves periph#24
maruel
reviewed
Dec 19, 2022
|
gohci |
|
Thanks Michael! Sadly my local lab died this weekend, so I can't test locally. This change looks good with the rename I commented on. |
|
@maruel is there a chance this gets merged anytime soon / more PRs are accepted? |
|
Thanks for the ping. I went out for the holidays and then completely forgot about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BCM2711 provides more alternate pin functions than the BCM283x. An extra mapping table mapping2711 is added by this change, which gets assigned to the
mappingvariable conditionally during driverGPIO.Init().The existing mapping is renamed to mapping283x, and used as default to keep tests working.
This change enables selecting alternate functions at runtime on a BCM2711 that were not supported by the existing BCM283x specific mapping, like GPIO4's UART3_TX; toggling between UART_TX and IN at runtime can be useful e.g. when sharing a single CAN transceiver between a CAN controller and a UART peripheral.
Resolves #24