add runner accessors to Command #123
Conversation
|
@austinsmorris can I get your thoughts on all the things mentioned here + a merge if things seem cool to you? |
| */ | ||
| public function getRunner() | ||
| { | ||
| return $this->runner; |
There was a problem hiding this comment.
If we can set any RunnerInterface, then we can return more than just Runner (fix typehint). Same holds true for the constructor. It can just be Runner Interface instead of Peridot\Runner\Runner.
|
Looks good, but why did the last commit drop coverage by 5%? |
|
@austinsmorris not sure on coverage details, as usual - hhvm coverage seems to be flawed. something with lib we are using? I definitely don't want that on the repo page. I'll look into it. |
|
@austinsmorris yeah, it looks like there is an open issue on hhvm coverage things, so I just reran the build and it put it back at 95. This should be good to merge. |
add runner accessors to Command
Fixes #121
Please note the intended 2.0 goal mentioned by #120 - once runner initialization is added to the command, we can have a default runner result of
Peridot\Runner\Runner, similar to how the default loader mechanism works in the command.