Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.19]: Tests: Port slim.request.form_hash to _POST #414

Closed
wants to merge 1 commit into from
Closed

[0.19]: Tests: Port slim.request.form_hash to _POST #414

wants to merge 1 commit into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 24, 2021

  1. Don't use slim internal details
  2. Be compatible with Slim 2.x
  3. Be compatible with Slim 3.x

@glensc glensc self-assigned this Jan 24, 2021
@glensc glensc changed the title Port slim.request.form_hash to _POST Tests: Port slim.request.form_hash to _POST Jan 24, 2021
@glensc glensc closed this Feb 12, 2021
@glensc glensc deleted the branch 0.19.x February 12, 2021 12:24
@glensc
Copy link
Contributor Author

glensc commented Feb 12, 2021

Revert unintended close:

@glensc glensc reopened this Feb 12, 2021
@glensc glensc changed the base branch from master to 0.19.x February 12, 2021 12:35
@glensc glensc changed the title Tests: Port slim.request.form_hash to _POST [0.19]: Tests: Port slim.request.form_hash to _POST Feb 12, 2021
@glensc glensc added this to the 0.19.2 milestone Jan 16, 2022
@glensc
Copy link
Contributor Author

glensc commented Jan 16, 2022

Not needed

@glensc glensc closed this Jan 16, 2022
@github-actions github-actions bot mentioned this pull request Jan 17, 2022
Merged
@glensc glensc deleted the form-testing branch January 18, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc