-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus exporter for PDO #305
Conversation
Partially done. I'll add a link to an example Grafana dashboard for https://performance.wikimedia.org/xhgui once I've made one.
Generally, Prometheus endpoints don't require any authentication. The information being exposed isn't anything which couldn't already be scraped from the index page. |
@dpifke you need to rebase against merge conflicts from the upstream |
This adds a /metrics endpoint, to export stats about the size of the database table. (This is currently PDO-only.) Bug: T256039 Change-Id: I5f83c6fe648db6065a46ef51a110fe4278bfaeaf
These queries aren't ideal to expose publicly. There is precedent for this with the We currently leave it to site-admins to stub these out at the web server level. I suppose we could do the same here, so perhaps nothing is required to change here but just wanted to point it out in case @glensc has thoughts on that. See also #308. |
merged as 4b25fc6, could not figure out how to push to developer branch (allow changes from maintainer was not enabled?) |
Is there a limitation of why this can't be implemented with MongoDB? or you were just not interested in implementing it yourself? ps: I've created an issue to track differences, would be nice to have your input, as you use PDO: #320 |
Nothing PDO-specific, I just didn't have a recent MongoDB instance set up with which to try to implement it. (MongoDB is infeasible to run at Wikimedia due to non-OSI-approved license and it having been removed from Debian.) Most of the functionality that's missing w/ the PDO backend is stuff we weren't really using; I'll add some notes to the linked task as to what we've identified. Our goal is to eventually contribute patches to bring it up to par. |
No description provided.