New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass options as-is to serialize #699

Merged

itsjwala merged 4 commits into master from serialize-options

Feb 6, 2023

Contributor

samarsault commented Jan 16, 2023 •

edited by itsjwala

Loading

Allow passing options passed to percySnapshot to DOM serialization function
This will ensure any future options passed don't require an update of ember SDK.


          pass options as-is to serialize

82a0aee

Contributor

itsjwala commented Jan 18, 2023

please update tests, update pr description


          test old cli

2c3e6be

samarsault requested a review from itsjwala

February 6, 2023 09:36


          add tests

b570225

itsjwala added the ✨ enhancement label

itsjwala approved these changes

View reviewed changes


          bump percy cli dependency

ac7a6c1

itsjwala merged commit 91d0025 into master

delete-merged-branch bot deleted the serialize-options branch

February 6, 2023 13:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment