Skip to content

Commit

Permalink
🐛 End browser process pipes during cleanup
Browse files Browse the repository at this point in the history
This is needed specifically for Windows
  • Loading branch information
wwilsman committed Feb 23, 2021
1 parent 8fcf269 commit cea5f24
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/core/src/discovery/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ export default class Browser extends EventEmitter {

// after closing, attempt to clean up the profile directory
await closed.then(() => new Promise(resolve => {
// needed to end hanging pipes on windows
this.process?.stdin.end();
this.process?.stdout.end();
this.process?.stderr.end();

/* istanbul ignore else: sanity */
if (this.profile) {
rimraf(this.profile, error => {
Expand Down

0 comments on commit cea5f24

Please sign in to comment.