🐛 End browser process pipes during cleanup

This is needed specifically for Windows
percy · Feb 23, 2021 · 7d153e8 · 7d153e8
1 parent ac1a812
commit 7d153e8
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/core/src/discovery/browser.js b/packages/core/src/discovery/browser.js
@@ -145,6 +145,11 @@ export default class Browser extends EventEmitter {
 
     // after closing, attempt to clean up the profile directory
     await closed.then(() => new Promise(resolve => {
+      // needed due to a bug in Node 12 - https://github.com/nodejs/node/issues/27097
+      this.process?.stdin.end();
+      this.process?.stdout.end();
+      this.process?.stderr.end();
+
       /* istanbul ignore else: sanity */
       if (this.profile) {
         rimraf(this.profile, error => {