Skip to content

Conversation

@dAdAbird
Copy link
Member

Although it may be technically omitted during redo, write_key_provider_info() now checks if there is a lock held.

I'll add tests covering this to #217 (I found this issue writing test for that PR)

Although it may be technically omitted during redo, write_key_provider_info() now checks if there is a lock held
@dAdAbird dAdAbird requested a review from dutow as a code owner April 23, 2025 11:23
@dAdAbird dAdAbird requested review from AndersAstrand and removed request for dutow April 23, 2025 11:23
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.60%. Comparing base (157230d) to head (7ebb00f).

❌ Your project status has failed because the head coverage (75.60%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #250      +/-   ##
=====================================================
- Coverage              75.66%   75.60%   -0.07%     
=====================================================
  Files                     22       22              
  Lines                   2490     2492       +2     
  Branches                 394      394              
=====================================================
  Hits                    1884     1884              
- Misses                   529      531       +2     
  Partials                  77       77              
Components Coverage Δ
access 72.82% <ø> (ø)
catalog 83.20% <0.00%> (-0.19%) ⬇️
common 92.50% <ø> (ø)
encryption 71.90% <ø> (ø)
keyring 72.07% <ø> (ø)
src 52.80% <ø> (ø)
smgr 96.96% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jeltz jeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR needs this fix. :)

Copy link
Collaborator

@AndersAstrand AndersAstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I should have added tests that exercised that code path.

@dAdAbird dAdAbird merged commit 4724ecb into percona:TDE_REL_17_STABLE Apr 23, 2025
22 checks passed
@dAdAbird dAdAbird deleted the redo_lock branch April 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants