Skip to content

Proof of concept: Ideas for cleaner TAP tests #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndersAstrand wants to merge 5 commits into from
Closed

Proof of concept: Ideas for cleaner TAP tests #249

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfd3b4e
Remove tests that can easily be done by pg_regrss
Apr 23, 2025
21dc7e2
Do not assert that test scaffolding works
Apr 23, 2025
b94a41f
Use Test::More assertions
Apr 23, 2025
856e6e8
Reformat SQL to make it easier to read
Apr 23, 2025
7f475e9
Add wrapper to make Andreas happy
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions contrib/pg_tde/t/001_basic.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,6 @@

PGTDE::psql($node, 'postgres', 'CREATE EXTENSION IF NOT EXISTS pg_tde;');

PGTDE::psql($node, 'postgres',
'SELECT extname, extversion FROM pg_extension WHERE extname = \'pg_tde\';'
);

PGTDE::psql($node, 'postgres',
'CREATE TABLE test_enc(id SERIAL,k INTEGER,PRIMARY KEY (id)) USING tde_heap;'
);

PGTDE::append_to_result_file("-- server restart");
$node->restart;

PGTDE::psql($node, 'postgres',
"SELECT pg_tde_add_database_key_provider_file('file-vault','/tmp/pg_tde_test_keyring.per');"
);
Expand All @@ -42,9 +31,6 @@
PGTDE::psql($node, 'postgres',
'INSERT INTO test_enc (k) VALUES (\'foobar\'),(\'barfoo\');');

PGTDE::psql($node, 'postgres', 'SELECT * FROM test_enc ORDER BY id ASC;');

PGTDE::append_to_result_file("-- server restart");
$node->restart;

PGTDE::psql($node, 'postgres', 'SELECT * FROM test_enc ORDER BY id ASC;');
Expand All @@ -63,10 +49,6 @@
$strings .= `strings $tablefile | grep foo`;
PGTDE::append_to_result_file($strings);

PGTDE::psql($node, 'postgres', 'DROP TABLE test_enc;');

PGTDE::psql($node, 'postgres', 'DROP EXTENSION pg_tde;');

$node->stop;

# Compare the expected and out file
Expand Down
20 changes: 0 additions & 20 deletions contrib/pg_tde/t/expected/001_basic.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
CREATE EXTENSION IF NOT EXISTS pg_tde;
SELECT extname, extversion FROM pg_extension WHERE extname = 'pg_tde';
extname | extversion
---------+------------
pg_tde | 1.0-rc
(1 row)

CREATE TABLE test_enc(id SERIAL,k INTEGER,PRIMARY KEY (id)) USING tde_heap;
psql:<stdin>:1: ERROR: principal key not configured
HINT: create one using pg_tde_set_key before using encrypted tables
-- server restart
SELECT pg_tde_add_database_key_provider_file('file-vault','/tmp/pg_tde_test_keyring.per');
pg_tde_add_database_key_provider_file
---------------------------------------
Expand All @@ -30,16 +20,6 @@ SELECT * FROM test_enc ORDER BY id ASC;
2 | barfoo
(2 rows)

-- server restart
SELECT * FROM test_enc ORDER BY id ASC;
id | k
----+--------
1 | foobar
2 | barfoo
(2 rows)

TABLEFILE FOUND: yes

CONTAINS FOO (should be empty):
DROP TABLE test_enc;
DROP EXTENSION pg_tde;