PMM-12673 Protobuf linters #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v3-api-breaking-changes #2612 +/- ##
===========================================================
+ Coverage 44.06% 44.09% +0.03%
===========================================================
Files 358 358
Lines 42087 42076 -11
===========================================================
+ Hits 18546 18554 +8
+ Misses 21947 21927 -20
- Partials 1594 1595 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
artemgavrilov
requested review from
a team,
idoqo,
BupycHuk and
JiriCtvrtka
as code owners
artemgavrilov
requested review from
ademidoff
and removed request for
a team
ademidoff
reviewed
Nov 21, 2023
Co-authored-by: Alex Demidoff <[email protected]>
ademidoff
approved these changes
Nov 22, 2023
| } | ||
| } | ||
| return res, nil | ||
| } | ||
|
|
||
| // Get selects a single Service by ID. | ||
| func (ss *ServicesService) Get(ctx context.Context, id string) (inventorypb.Service, error) { //nolint:unparam,ireturn | ||
| func (ss *ServicesService) Get(ctx context.Context, id string) (inventoryv1.Service, error) { //nolint:unparam,ireturn |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:unparam,ireturn is unused for linter "unparam" (nolintlint)
BupycHuk
approved these changes
Nov 23, 2023
| @@ -538,10 +538,10 @@ func (m *PGStatMonitorQAN) makeBuckets(current, cache map[time.Time]map[string]* | |||
| Queryid: currentPSM.QueryID, | |||
| NumQueries: count, | |||
| ClientHost: currentPSM.ClientIP, | |||
| AgentType: inventorypb.AgentType_QAN_POSTGRESQL_PGSTATMONITOR_AGENT, | |||
| AgentType: inventoryv1.AgentType_AGENT_TYPE_QAN_POSTGRESQL_PGSTATMONITOR_AGENT, | |||
There was a problem hiding this comment.
can we somehow get rid of this duplication(AgentType_AGENT_TYPE)?
There was a problem hiding this comment.
Not with default compiler: golang/protobuf#513
However there is a wrapper for compiler that can apply some changes to generated code: https://github.com/alta/protopatch
But I'm not sure that we need to add an extra layer to our generation process.
There was a problem hiding this comment.
Created ticket: https://jira.percona.com/browse/PMM-12723
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Update process | |||
|
|
|||
| Update of PMM Server which includes `managed` and other components is triggered by sending a [StartUpdate](https://github.com/percona/pmm/blob/6761010b8b30042936c58c022752f6b57581afee/api/serverpb/server.proto#L325) message. | |||
| Update of PMM Server which includes `managed` and other components is triggered by sending a [StartUpdate](https://github.com/percona/pmm/blob/PMM-12673-protobuf-linters/api/server/v1/server.proto#L260) message. | |||
There was a problem hiding this comment.
should the link be to a branch?
There was a problem hiding this comment.
I will change it later to something else (commin or v3 branch) because current commit also won't exist after merge (squash)
artemgavrilov
merged commit 64fcdc3
into
v3-api-breaking-changes
28 of 30 checks passed
ademidoff
added a commit
that referenced
this pull request
Jul 18, 2024
* PMM-12624 Single inventory service add endpoint (#2591) * PMM-12529 provide one AddService for all types of services * PMM-12529 use context in transactions * PMM-12529 remove rpc AddMySQLService * PMM-12624 remove rpc AddMongoDBService * PMM-12624 remove rpc AddPostgreSQLService * PMM-12624 remove rpc AddProxySQLService * PMM-12624 remove rpc AddHAProxyService * PMM-12624 remove rpc AddExternalService * PMM-12624 final cleanup * PMM-12624 fix the API tests * PMM-12624 add and update the API docs * PMM-12624 fix duplicate entry in the sample payload * PMM-12624 return straight away * PMM-12624 rename the messages to ...Params * PMM-12624 reorder the message fields * Update docs/api/inventory/add-node.md Co-authored-by: Nurlan Moldomurov <[email protected]> --------- Co-authored-by: Nurlan Moldomurov <[email protected]> * PMM-12681 remove deprecated node add endpoints (#2632) * PMM-12681 remove deprecated Node/Add... endpoints * PMM-12681 restore the Makefile * PMM-12681 trigger CI * PMM-12681 fix the test * PMM-12681 rename NodeRequest to NodeParams * PMM-12681 fix the error messages in tests * PMM-12529 regen descriptors * PMM-12529 take descriptors from the parent branch * PMM-12529 regen descriptors * PMM-12529 regen descriptors * PMM-12673 Protobuf linters (#2612) * PMM-12673 Replace _INVALID suffix in enums with _UNSPECIFIED * PMM-12673 Remove unused imports * Refactor all protobuf enums * PMM-12673 Fix * PMM-12673 Fix qan tests * PMM-12673 Add service suffix to all grpc service names * PMM-12673 Fix QAN GetReport request/response naming * PMM-12673 Fix * PMM-12673 Fix * PMM-12673 Fix tests * PMM-12673 Fix tests * PMM-12673 Fix test * PMM-12673 Refactor user API requests and responses * PMM-12673 Fix tests * PMM-12673 Fix tests * PMM-12673 Refactor requests/responses names * PMM-12673 Refactoring * PMM-12673 Fix * PMM-12673 Fix * PMM-12673 Fix * PMM-12673 Refactoring * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Fix * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Restructure * PMM-12673 Fix * PMM-12673 Configure buf lint, setup CI action * PMM-12673 Cleanup * PMM-12673 Fix CI * PMM-12673 Rename * PMM-12673 Trigger API lint warning * PMM-12673 Remove redundant go_package option * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Refactoring * PMM-12673 Fix buf lint in CI * PMM-12673 Fix * PMM-12673 add debug data * PMM-12673 Add debug data [skip ci] * PMM-12673 Trigger CI * PMM-12673 Debug * PMM-12673 Remove debug data * PMM-12673 Refactoring * PMM-12673 Fix some linter warnings * PMM-12673 Fix test * Update docs/managed/update-process.md * Update api/buf.yaml Co-authored-by: Alex Demidoff <[email protected]> * PMM-12673 Fix API tests * Fix import allias * PMM-12673 Post-merge fix --------- Co-authored-by: Alex Demidoff <[email protected]> * PMM-12646 Exclude inventory API from public spec (#2644) * PMM-12646 Exclude inventory API from public API spec * PMM-12646 Trigger CI * PMM-6722 Preserve empty JSON fields in API responses (#2645) * PMM-6722 enable 'EmitUnpopulated' serialization option * PMM-6722 Add API test * PMM-6722 Add license header * PMM-6722 Fix linter * PMM-6722 Fix API tests * PMM-6722 Fix API test * PMM-6722 Fix API test * PMM-6722 Fix API tests * Post-merge fixes * Cleanup * ci: trigger the build * Fix after merge * Fix after merge * PMM-12624 single inventory agents add endpoint (#2722) * PMM-12624 migrate to a single exporter/add endpoint * PMM-12624 update descriptors to silence errors * PMM-12624 upgrade mongo to at least 4.4 * PMM-12624 revert proto fields renumbering * PMM-12624 rename AddExporter to AddAgent * PMM-12624 add Agents to refactoring * PMM-12624 make gen * PMM-12624 rename addExporter to addAgent * PMM-12624 add the documentation * PMM-12624 make grpc methods private * PMM-8019 Support partial updates of settings and other entities (#2705) * PMM-8019 Get rid of enable/disable flags in settings * PMM-8019 Fixes * PMM-8019 Fix * PMM-8019 Cleanup * PMM-8019 Fix tests * PMM-8019 Fixes * PMM-8019 Fix migrations order * PMM-8019 Fix DB migrations * PMM-8019 Fix tests * PMM-8019 Update docs * PMM-8019 Fix * PMM-8019 Make check enabling toogle optional * PMM-8019 Make role update params optional * PMM-8019 Fix API tests * PMM-8019 Use optional fields for tour flags * PMM-8019 Use optionals instead of wrappers in API where it's possible * PMM-8019 Comments * PMM-8019 Fix tests * PMM-8019 Fix linters * PMM-8019 Fix * PMM-12678 Reset protobuf field nums, remove all deprecated stuff from API (#2733) * PMM-12678 Reorder protobuf fields * PMM-12678 Fix tests * PMM-12678 Mark some fileds as reserved * PMM-12678 Cleanup * PMM-12678 Fix tests * PMM-12678 Fix tests * PMM-12678 Cleanup * PMM-12678 Cleanup * PMM-12678 Cleanup * PMM-12678 Cleanup * PMM-12678 Fix mocks * PMM-12678 Fix proto fields numbering * PMM-12677 remove STT naming (#2779) * PMM-12677: rename all stt usages to advisors * rename stt in query * PMM-12677 fix migrations (#2812) * add null check to values before re-use We try to re-use existing values for disabled checks and check intervals. But it is possible these values does not exist, leading to malformed JSON. This adds a null check, and only re-use these existing settings if they exist. * Update managed/models/database.go --------- Co-authored-by: Alex Demidoff <[email protected]> * PMM-12811 single agents change endpoint (#2777) * PMM-12811 fix a typo * PMM-12811 fix tests * PMM-12811 modify agents.proto * PMM-12811 modify agents_server and tests * PMM-12811 fix API tests * PMM-12811 fix linter warning * PMM-12811 increase container wait time * PMM-12811 print docker logs on failure * PMM-12811 increase the container wait time again * PMM-12811 try exit-code param for container launch * PMM-12811 check the container exit code * PMM-12811 launch pmm w/o waiting * PMM-12811 launch the container manually * PMM-12811 simplify, remove redundant methods * PMM-12811 rename exporter to agent in proto * PMM-12811 document the change * PMM-12811 fix API tests * PMM-12811 fix platform_test.go * PMM-12811 prefer a single enable boolean vs paired * PMM-12811 make custom_labels map optional * PMM-12811 fix Advisor params * PMM-12811 get rid of remove_custom_labels field * PMM-12811 remove a duplicate test * PMM-12811 follow up on review * PMM-12811 pass context to changeAgent * PMM-12811 move tableCount to MysqldExporter * PMM-12811 pass context around, fix tests * PMM-12811 add an annotation about one param * PMM-12811 fix Azure test * PMM-12677 stt naming cleanup (#2805) * update tests * rename security checks to advisor checks * update test files * update route * PMM-12836 restructure management API (#2814) * PMM-12836 restructure alerting api * PMM-12836 restucture api-tests * PMM-12836 modify alerting for swagger * PMM-12836 restructure backup api * PMM-12836 make gen after rebase * PMM-12836 restructure bump api * PMM-12836 remove outdated json specs * PMM-12836 regenerate proto specs * PMM-12836 restructure role api * PMM-12836 restructure advisors api * PMM-12836 restructure qan api, promote to v1 * PMM-12836 add qan.v1 to the main swagger spec * PMM-12836 restructure azure api * PMM-12836 restructure actions api * PMM-12836 fix lint errors * PMM-12836 fix api-tests * PMM-12836 regenerate code * PMM-12836 remove grpc wrappers for node & mysql * PMM-12836 fix the comment * PMM-12836 remove grpc wrappers for mongo, pg and proxysql services * PMM-12836 make platform API lowercase * PMM-12836 remove grpc wrapper for annotation service * PMM-12836 remove the comments * PMM-12836 fix lint error * PMM-12836 revert QAN migration to one service * chore: run make gen * chore: fix linter errors * chore: fix tests * chore: fix linter errors * chore: fix more linter errors * chore: fix more linter errors * PMM-12913 Use regular http verbs (#2828) * PMM-12913 fix logrus' field name for dump * PMM-12913 refactor empty proto messages * PMM-12913 make /updates and /settings lowercase * PMM-12913 fix linter errors * PMM-12913 merge all QAN endpoints into one service * PMM-12913 update QAN endpoints with summary and description * PMM-12913 fix linter errors * PMM-12913 merge mongodb to management/service * PMM-12913 merge proxysql to management/service * PMM-12913 merge postgresql & mysql to management/service * PMM-12913 merge external, haproxy & rds to management/service * PMM-12913 merge anotation & node to management/service * PMM-12913 merge MgmtNode to MgmtService * PMM-12913 merge MgmtAgent to MgmtService * PMM-12913 merge Azure to MgmtService * PMM-12913 rename Service to ManagementService * PMM-12913 provide a migration doc * PMM-12913 rename MgmtService to ManagementServiceV1Beta * Revert "PMM-12913 refactor empty proto messages" This reverts commit a4e9545. * PMM-12913 revert the addition of google.protobuf.Empty * PMM-12913 remodel some APIs * PMM-12913 move table_count to the beginning of rds.proto * PMM-12913 rename RestoreHistoryService to RestoreService * PMM-12913 fix the message name * PMM-12913 move /v1/backup/Backups/Restore to RestoreService * PMM-12913 merge changes from parent * PMM-12913 fix the linter error * PMM-12913 remove table_count from rds.proto * PMM-12913 fix null pointer ref in supervisord.go * chore: remove unused imports in proto files * chore: run make gen * test * Minor readibility improvements * Linguistic review * Linguistic review * Merge branch 'v3' into v3-api-breaking-changes * PMM-13090: Sync environment variables with v3-api-breaking-changes (#2982) * PMM-12619: Make PMM environment variables more consistent (#2857) * refactored environment variables * update migration doc * replace test line * drop no lint rule * fix parser tests * re-order table values * remove deprecated env variables * fix tests * use singluar advisor * introduce PMM_DEV_ prefix for dev-related variables * clean up environment variables * drop printf * drop unused variable * update tests * add notes for removed variable * update oauth variables * update changed variable list * update variable check validation * refactor tests * surpress linter error * fix docker readme * restore error checks * include backup management variable * Update for grammar * PMM-13020 Drop identifier prefixes (#2970) * PMM-13020 Add a db migration * PMM-13020 strip agent_id, node_id, action_id * PMM-13020 drop service_id * PMM-13020 drop machine_id * PMM-13020 drop location_id * Update agent/agents/mysql/slowlog/slowlog_test.go Co-authored-by: Nurlan Moldomurov <[email protected]> * PMM-13020 fix wrong strip-offs * PMM-13020 fix text output spacing * PMM-13020 fix text output spacing * PMM-13020 drop role_id migration * PMM-13020 fix text output spacing * PMM-13020 fix wrong agent_id * PMM-13020 fix slowlog jsons * PMM-13020 fix scrape config and rds tests * PMM-13020 fix scrape config test * PMM-13020 fix victoriametrics test * PMM-13020 fix node_helpers test * PMM-13020 fix grafana test (name was too long) * PMM-13020 strip prefixes in qan fixtures * PMM-13020 fix QAN tests * PMM-13020 cut the prefix when reading params * PMM-13020 fix the job_name in vm tests * PMM-13020 update the docs --------- Co-authored-by: Nurlan Moldomurov <[email protected]> * Merge branch 'v3' into v3-api-breaking-changes * fix: node.proto and node_test * fix: linter errors * PMM-12913 Migrate api endpoints to REST (#2880) * PMM-12913 Add a resource name to endpoints ending with /v1 * PMM-12913 fix the linter error (goconst) * PMM-12913 migrate /v1/version * PMM-12913 migrate /v1/readyz * PMM-12913 all endpoints begin with `/v1` * PMM-12913 make gen * PMM-12913 migrate /v1/settings/Get * PMM-12913 fix unit test fo /v1/server/settings * PMM-12913 migrate /v1/settings/Change * PMM-12913 migrate /v1/AWSInstanceCheck * PMM-12913 fix alerting api tests * PMM-12913 fix ManagementService being disabled * PMM-12913 fix backup API tests * PMM-12913 temporarily allow /v1/version * PMM-12913 update admins' readme * PMM-12913 fix the Agent connect path in auth * PMM-12913 fix wrong grpc paths * PMM-12913 fix the port in readme * PMM-12913 fix some grpc paths * PMM-12913 add check-agent-setup script * PMM-12913 migrate /v1/server/leaderHealthCheck endpoint * PMM-12913 migrate /v1/settings/Get * PMM-12913 fix the api test * PMM-12913 migrate /v1/updates/Start * PMM-12913 fix actions * PMM-12913 migrate /logs.zip * PMM-12913 fix auth_server_test * PMM-12913 migrate /v1/updates/Status * PMM-12913 migrate /v1/users * PMM-12913 migrate /v1/inventory/Agents * PMM-12913 fix logs_test * PMM-12913 use an interface for commonAgentParams * PMM-12913 re-add `/agent_id/` * PMM-12913 migrate /v1/inventory/Agents/Get * PMM-12913 migrate /v1/inventory/Agents/Remove * PMM-12913 migrate /v1/inventory/Agents/GetLogs * PMM-12913 migrate /v1/inventory/Nodes * PMM-12913 migrate /v1/inventory/Services * PMM-12913 fix tests for /v1/inventory/services * PMM-12913 migrate /v1/management/Service * PMM-12913 migrate /v1/actions * PMM-12899 migrate /v1/alerting endpoints * PMM-12899 migrate /v1/advisors emdpoints * PMM-12899 rename BackupsService to BackupService * PMM-12899 migrate /v1/backup/Artifacts * PMM-12899 migrate /v1/backup/Backups * PMM-12913 refactor /v1/backups/locations * PMM-12913 refactor /v1/backups/restores * PMM-12913 refactor /v1/dumps * PMM-12913 move dump and role API to v1beta1 folder * PMM-12913 refactor /v1/role, rename tp /v1/accesscontrol * PMM-12913 refactor /v1/management/nodes {Get,LIst} * PMM-12913 refactor /v1/management/services/List * PMM-12913 refactor /v1/management/services/azure * PMM-12913 refactor /v1/management/agent/List * PMM-12913 migrate /v1/platform * PMM-12913 migrate /v1/qan * PMM-12913 refactor the primitive types in alerting.proto * PMM-12913 fix a few linter errors * PMM-12913 do not show CollectorService in swagger * PMM-12913 split /backup/GetLogs up to two endpoints * PMM-12913 fix restore tests * PMM-12913 update migration examples * PMM-12913 fix /v1/qan/metrics:getFilters being unavailable * PMM-12913 fix the linter error * PMM-12913 fix /v1/qan/metrics:getFilters test * PMM-12913 update migration examples * PMM-12913 fix an iteration bug * PMM-12913 fix an issue with QAN failing to persist data * PMM-12913 remove debug output * PMM-12913 auth_server fixes for QAN * PMM-12913 fix agent API tests * PMM-12913 fix the QAN URL routing issue * PMM-12913 remove the unnecessary PMM_NICER_API * PMM-12913 add the routing error handler * PMM-12913 minor syntax fixes * PMM-12913 remove PMM_LESS_LOG_NOISE envvar * PMM-12913 remove ID normalizers * PMM-12913 update the migration doc * PMM-12913 better error handling * PMM-12913 fix /v1/backups/artifacts/{artifact_id} delete endpoint * PMM-12913 simplify setup.py * PMM-12913 fix a linter error * PMM-12913 merge ArtifactService with BackupService * Revert "PMM-12913 better error handling" This reverts commit add2d3f. * PMM-12913: regenerate code, fix Makefile.include * PMM-12913: fix node_test * PMM-12913: fix UnregisterNode method name * PMM-12857 fix API tests * PMM-12857 fix agent tests * PMM-12857 fix auth_test and clean up readyz_test * PMM-12857 fix settings_test * PMM-12857 fix auth_test * PMM-13054 fix the backup test * PMM-13054 fix advisor tests * PMM-13054 fix auth_server tests again * PMM-13054 remove redundant functionality * PMM-13054 fix actions tests * PMM-13054 minor cleanup * PMM-13054 disable platform tests until the env is ready * PMM-13054 fix advisors_test * PMM-13054 try better error msg to debug failures * PMM-13054 fix alerting_test * Revert "PMM-13054 try better error msg to debug failures" This reverts commit 862ec3b. --------- Co-authored-by: Alex Demidoff <[email protected]> Co-authored-by: Nurlan Moldomurov <[email protected]> Co-authored-by: Michael Okoko <[email protected]> Co-authored-by: Catalina A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12673
Link to the Feature Build: SUBMODULES-3453
https://protobuf.dev/programming-guides/style/
Servicesuffixpbsuffix in api package names