Skip to content

Conversation

@dliakhov
Copy link
Contributor

@dliakhov dliakhov commented May 4, 2023

In the scope of this PR were created two datapoints which send data about installed and available PostgresSQL extensions of the connected databases.

PMM-11984

Link to the Feature Build: Percona-Lab/pmm-submodules#3258

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@dliakhov dliakhov requested a review from a team as a code owner May 4, 2023 16:20
@dliakhov dliakhov requested review from JiriCtvrtka and idoqo and removed request for a team May 4, 2023 16:20
Comment on lines 301 to 302
- metric_name: "4"
label: "service_name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to collect service_name, it might contain personal data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed that, thanks

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #2083 (1d5bc13) into main (c9edf0b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 1d5bc13 differs from pull request most recent head 7348b85. Consider uploading reports for the commit 7348b85 to get more accurate results

@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
- Coverage   42.63%   42.56%   -0.07%     
==========================================
  Files         387      387              
  Lines       47651    47494     -157     
==========================================
- Hits        20315    20217      -98     
+ Misses      25430    25371      -59     
  Partials     1906     1906              
Flag Coverage Δ
managed 43.69% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
managed/services/victoriametrics/scrape_configs.go 78.64% <100.00%> (ø)

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dliakhov dliakhov merged commit 9ee9f6f into main May 19, 2023
@dliakhov dliakhov deleted the PMM-11984-add-datapoints-to-show-installed-and-available-postgressql-extensions branch May 19, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants