Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13543 Fix socket path failure. #969

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Nov 18, 2024

PMM-13543 (optional, if ticket reported)

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@BupycHuk BupycHuk requested a review from a team as a code owner November 18, 2024 13:28
@BupycHuk BupycHuk requested review from ademidoff and JiriCtvrtka and removed request for a team November 18, 2024 13:28
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (dc46ed5) to head (0dd9dfd).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
main.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   70.88%   69.85%   -1.04%     
==========================================
  Files          28       28              
  Lines        3569     3589      +20     
==========================================
- Hits         2530     2507      -23     
- Misses        904      944      +40     
- Partials      135      138       +3     
Flag Coverage Δ
agent 69.85% <62.50%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk merged commit de9f4b3 into main Nov 19, 2024
14 checks passed
@BupycHuk BupycHuk deleted the PMM-13543-socket-failure-fix branch November 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants