-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change some tests to no longer use subprocess #386
Conversation
out of curiosity, how much of an improvement to test time did this yield? |
def test_args_expansion( | ||
pth=None, cmd=None, appendix=list(), dry=True | ||
) -> Tuple[bytes, bytes, int]: | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a sentence as to what this is for? I can't infer why we need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
this is great! I don't quite see why you're using a list of strings instead of just a dict, the way markmeld does it. Can you explain that? basically, I think you can do all of this without needing |
This change allows for decreasing test time from 78 secs to 43 secs. I had issues with passing a dict as Also, there was already a good example using a list of strings for the subprocess method that fit into the testing structure, so I simply used that. Looking at the markmeld example, there is only one test that uses the approach and it is expected to fail:
I'm wondering if the markmeld example is not working exactly as we intend it to but is failing anyway which is what our test wants to see. |
This addresses:
#353