Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divvy reintegration #378

Merged
merged 18 commits into from
May 10, 2023
Merged

divvy reintegration #378

merged 18 commits into from
May 10, 2023

Conversation

ayobi
Copy link
Member

@ayobi ayobi commented Apr 30, 2023

should be ready now

@ayobi
Copy link
Member Author

ayobi commented Apr 30, 2023

I just realized you can add changes to the same pull request, I was closing and making a new pull request every time I made a change. My bad.

Copy link
Contributor

@nsheff nsheff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a few questions/comments.

config Outdated Show resolved Hide resolved
hello_looper_results/count_lines_frog_1.sub Outdated Show resolved Hide resolved
looper/__init__.py Outdated Show resolved Hide resolved
looper/__init__.py Outdated Show resolved Hide resolved
looper/conductor.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
looper/__main__.py Outdated Show resolved Hide resolved
@nsheff
Copy link
Contributor

nsheff commented May 4, 2023

Hi @ayobi -- what's the status of this PR? were you able to get all the divvy integration completed?

@ayobi
Copy link
Member Author

ayobi commented May 10, 2023

Hi @nsheff, sorry for the delay, yes, all is integrated, I'll go ahead and merge PR now.

@ayobi ayobi merged commit 1bdbb5c into dev May 10, 2023
@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

did you finish the docs integration?

@ayobi
Copy link
Member Author

ayobi commented May 10, 2023

Ah, adding that now

@ayobi
Copy link
Member Author

ayobi commented May 10, 2023

Those docs have been added and the mkdocs.yaml is updated on dev, I'm not seeing any changes to https://looper.databio.org/en/dev/ though, is there anything else I need to do in order to see how it looks for the dev version of the docs?

@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

I think the docs builds are failing because this might no longer be an allowed way to specify a requirement:

-e git+git://github.com/pepkit/pipestat@master#egg=pipestat

@ayobi
Copy link
Member Author

ayobi commented May 10, 2023

Ah ok. I can look into that but currently having issues running mkdocs locally, some issues with mkdocs and jinja2 that I am running into so it's hard to debug at the moment.

@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

it's probably solvable with a quick google search.

@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

that did it

@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

you need to update the changelog: https://looper.databio.org/en/dev/changelog/

@nsheff
Copy link
Contributor

nsheff commented May 10, 2023

also the images aren't loading correctly: https://looper.databio.org/en/dev/cli_divvy/

@ayobi
Copy link
Member Author

ayobi commented May 10, 2023

I'll fix that now

@ayobi
Copy link
Member Author

ayobi commented May 10, 2023

Ok, fixed the images that were in the Intro for divvy. The CLI comes from a Juypter file, not sure if I need to do something extra for that but the header is rendering for that. Also, I made the entry for 1.5 in the changlog, so far I put in the divvy additions, not sure what else is coming in this release so we can modify that when we're ready.

@donaldcampbelljr donaldcampbelljr deleted the divvy_reintegration branch August 4, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants