-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
divvy reintegration #378
divvy reintegration #378
Conversation
…into divvy_reintegration
I just realized you can add changes to the same pull request, I was closing and making a new pull request every time I made a change. My bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, just a few questions/comments.
Hi @ayobi -- what's the status of this PR? were you able to get all the divvy integration completed? |
Hi @nsheff, sorry for the delay, yes, all is integrated, I'll go ahead and merge PR now. |
did you finish the docs integration? |
Ah, adding that now |
Those docs have been added and the |
I think the docs builds are failing because this might no longer be an allowed way to specify a requirement:
|
Ah ok. I can look into that but currently having issues running mkdocs locally, some issues with mkdocs and jinja2 that I am running into so it's hard to debug at the moment. |
it's probably solvable with a quick google search. |
that did it |
you need to update the changelog: https://looper.databio.org/en/dev/changelog/ |
also the images aren't loading correctly: https://looper.databio.org/en/dev/cli_divvy/ |
I'll fix that now |
Ok, fixed the images that were in the Intro for divvy. The CLI comes from a Juypter file, not sure if I need to do something extra for that but the header is rendering for that. Also, I made the entry for 1.5 in the changlog, so far I put in the divvy additions, not sure what else is coming in this release so we can modify that when we're ready. |
should be ready now