Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name cannot be inferred when loading PEP from csv #484

Closed
donaldcampbelljr opened this issue Mar 14, 2024 · 1 comment
Closed

Project name cannot be inferred when loading PEP from csv #484

donaldcampbelljr opened this issue Mar 14, 2024 · 1 comment

Comments

@donaldcampbelljr
Copy link
Contributor

          > However, Looper goes on to later call `prj.name` and it fails with the exception: `Project name inference isn't supported on a project that lacks a config file.`

This would be a separate bug, then, because those are valid projects.

Originally posted by @nsheff in #456 (comment)

@donaldcampbelljr
Copy link
Contributor Author

Currently, in Peppy, this will search for the name field in the project config. If none is given, it will default to project as the name.
However, with loading from a csv, there is no project config and Peppy raises a NotImplementedError:
https://github.com/pepkit/peppy/blame/6913e77f046b60d74681284ce4c22a133cca4f5f/peppy/project.py#L1048-L1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant