Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.12.0 #110

Merged
merged 5 commits into from
Jan 23, 2023
Merged

V0.12.0 #110

merged 5 commits into from
Jan 23, 2023

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Jan 20, 2023 •
edited
Loading

Added functionality that adds gse soft content to config file.
Fixed #108 #109

@khoroshevskyi khoroshevskyi requested a review from nsheff January 20, 2023 22:40
@nsheff
Copy link
Contributor

nsheff commented Jan 20, 2023

My only comments are:

  1. make sure you tag this PR to the issue it is solving (by adding "Fix ...." in the PR description)
  2. if it's adding a new feature it should probably by a minor version increment, not a patch version increment.

This was linked to issues Jan 20, 2023
Update pandas version #108
Closed
Make sure Project level attributes are added to project file #109
Closed
@khoroshevskyi
Copy link
Member Author

My only comments are:

  1. make sure you tag this PR to the issue it is solving (by adding "Fix ...." in the PR description)
  2. if it's adding a new feature it should probably by a minor version increment, not a patch version increment.

Ok, I will change it to version 0.12.0

@khoroshevskyi khoroshevskyi changed the title V0.11.3 V0.12.0 Jan 23, 2023
@khoroshevskyi khoroshevskyi merged commit e38a70d into master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsheff nsheff nsheff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure Project level attributes are added to project file Update pandas version
2 participants
@khoroshevskyi @nsheff