Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to run schema files after main schema file too #57

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

nadege
Copy link
Contributor

@nadege nadege commented Feb 12, 2020

Adding a feature similar to peopledoc/django-north#37
making it possible to run schema files not only before the main schema but also after.
Marked previous option additional_schema_file as deprecated (not sure of my way of doing it though)

Also did a bit of gardening in the docs.

Successful PR Checklist:

  • Tests
  • Documentation (optionally: run spell checking)
  • Had a good time contributing? yay 😃 But better test coverage would make contributing easier.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #57 into master will increase coverage by 8.58%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   56.35%   64.93%   +8.58%     
==========================================
  Files          14       14              
  Lines         598      616      +18     
  Branches       81       86       +5     
==========================================
+ Hits          337      400      +63     
+ Misses        254      208      -46     
- Partials        7        8       +1
Flag Coverage Δ
#integration 45.29% <68%> (+32.91%) ⬆️
#unit 54.54% <16%> (-0.64%) ⬇️
Impacted Files Coverage Δ
septentrion/cli.py 0% <0%> (ø) ⬆️
septentrion/configuration.py 80.88% <100%> (+4.31%) ⬆️
septentrion/migrate.py 58.42% <89.47%> (+58.42%) ⬆️
septentrion/files.py 90.56% <0%> (+3.77%) ⬆️
septentrion/core.py 76.05% <0%> (+4.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fb514...47a3dfc. Read the comment docs.

Copy link
Contributor

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ! ✨

Thank you !

@ewjoachim
Copy link
Contributor

Had a good time contributing? yay smiley But better test coverage would make contributing easier.

Yep #29

@ewjoachim ewjoachim merged commit 38d2f30 into master Feb 12, 2020
@ewjoachim ewjoachim deleted the after-before-schema-files branch February 12, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants