Define an ember-core, update configuration to follow recent ember changes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndekeister-us
approved these changes
Feb 19, 2021
|
I'm not a big fan of the trailing comma in array and object ><. Is it possible to disable this rule? |
yonmey
approved these changes
Feb 19, 2021
GreatWizard
force-pushed
the
refactor/v3
branch
from
9b9ad4a
to
359fca3
Compare
GreatWizard
force-pushed
the
refactor/v3
branch
6 times, most recently
from
631b3dc
to
044c1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #63
close #69
Breaking changes
ember-testconfiguration not needed anymore in our addon with dummy app (Define an ember-core, update configuration to follow recent ember changes #70)prettier-eslint-clifrom dependency (Define an ember-core, update configuration to follow recent ember changes #70)Features