Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ember-recommended in every ember configs #51

Merged
merged 1 commit into from
Apr 6, 2020
Merged

fix: add ember-recommended in every ember configs #51

merged 1 commit into from
Apr 6, 2020

Conversation

GreatWizard
Copy link
Contributor

@GreatWizard GreatWizard commented Apr 6, 2020 •
edited
Loading

Fix #50

Fix

Add missing ember-recommanded configuration in ember.js and ember-test (#51)

It re-adds ursefull rules likes:

  • ember/no-arrow-function-computed-properties
  • ember/require-return-from-computed
  • ember/avoid-leaking-state-in-ember-objects
  • ...

@GreatWizard GreatWizard requested a review from a team as a code owner April 6, 2020 08:14
@GreatWizard GreatWizard merged commit 4b53444 into master Apr 6, 2020
@GreatWizard GreatWizard deleted the fix/ember-recommended branch April 6, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrChocolatine MrChocolatine MrChocolatine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some essential rules are not linted anymore in v2.0.0
2 participants
@GreatWizard @MrChocolatine