Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): add CODEOWNERS #46

Merged
merged 1 commit into from
Dec 23, 2019
Merged

feat(github): add CODEOWNERS #46

merged 1 commit into from
Dec 23, 2019

Conversation

MrChocolatine
Copy link
Contributor

Add CODEOWNERS file.

@MrChocolatine MrChocolatine requested a review from a team December 20, 2019 17:26
@MrChocolatine MrChocolatine self-assigned this Dec 20, 2019
xcambar
xcambar approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@xcambar xcambar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a public repo, the group is private... I'm not sure it will work, but we can try.

@MrChocolatine
Copy link
Contributor Author

It's a public repo, the group is private... I'm not sure it will work, but we can try.

I did not find anything stating it should be a problem within a public repository so I guessed it should work.

@MrChocolatine MrChocolatine merged commit 1358fb2 into master Dec 23, 2019
@MrChocolatine MrChocolatine deleted the add-code-owners branch December 23, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcambar xcambar xcambar approved these changes

Assignees

@MrChocolatine MrChocolatine

Labels
enhancement ☺
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrChocolatine @xcambar