wip

.eslintrc.js

@@ -1,7 +1,3 @@
 module.exports = {
-  root: true,
-  env: {
-    node: true
-  },
-  extends: ["./index.js"]
+  extends: ["./node.js"]
 }

.gitignore

@@ -1,8 +1,6 @@
 # dependencies
 node_modules
 
-# Only apps should have lockfiles
-yarn.lock
 package-lock.json
 
 # misc

README.md

@@ -7,51 +7,59 @@
 ## Installation
 
 In your project, remove exisiting ESLint's plugins or configuration, then:
-```shell
-npm install --save-dev peopledoc/eslint-config-peopledoc
-```
-
-If you add this configuration to a project using Ember 3.12+, you need to install `babel-eslint`:
 
 ```sh
 # with npm
-npm install --save-dev babel-eslint
+npm install --save-dev eslint-config-peopledoc
 
 # or with yarn
-yarn add babel-eslint --dev
+yarn add eslint-config-peopledoc --dev
 ```
 
-
 ## Usage
 
-In your project, edit your [`eslint` configuration](https://eslint.org/docs/user-guide/getting-started#global-installation-and-usage) to extend `peopledoc` ESLint config:
+In your project, edit your [`eslint` configuration](https://eslint.org/docs/user-guide/getting-started#global-installation-and-usage) to extend `peopledoc` ESLint config.
+
+Preset configurations are available for:
+
+**Vanilla JS:**
 
 ```js
 module.exports = {
-  root: true,
-  extends: ['peopledoc'],
-  rules: {}
-};
+  extends: ["peopledoc"]
+}
 ```
 
-Preset configurations are available for:
+**Ember:**
 
-**Vanilla JS:**
+```js
+module.exports = {
+  extends: ["peopledoc/ember"]
+}
+```
+
+**Ember Tests:**
 
 ```js
-extends: ['peopledoc']
+module.exports = {
+  extends: ["peopledoc/embertest"]
+}
 ```
 
-**Ember:**
+**Node**
 
 ```js
-extends: ['peopledoc/ember']
+module.exports = {
+  extends: ["peopledoc/node"]
+}
 ```
 
 **ES5 only**
 
 ```js
-extends: ['peopledoc/es5']
+module.exports = {
+  extends: ["peopledoc/es5"]
+}
 ```
 
 ### Formatting Code

core.js → base.js

@@ -1,12 +1,4 @@
 module.exports = {
-  extends: [],
-  env: {
-    es6: true
-  },
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: "module"
-  },
   rules: {
     // ES6
     "arrow-parens": ["error", "always"],

ember.js

@@ -1,34 +1,23 @@
 module.exports = {
+  root: true,
   env: {
-    browser: true,
-    embertest: true
+    browser: true
   },
-  globals: {
-    server: true, // mirage
-    withFeature: true // feature flag
-  },
-  parser: 'babel-eslint',
+  parser: "babel-eslint",
   parserOptions: {
     ecmaVersion: 2018,
     sourceType: "module",
     ecmaFeatures: {
       legacyDecorators: true
     }
   },
-  plugins: ["ember"],
+  plugins: ["ember", "ember-suave"],
   extends: [
     "eslint:recommended",
-    "plugin:ember/recommended",
     "plugin:ember-suave/recommended",
-    "./core.js"
+    "./base.js"
   ],
   overrides: [
-    {
-      files: ["testem.js"],
-      rules: {
-        camelcase: 0
-      }
-    },
     // node files
     {
       files: [
@@ -43,12 +32,6 @@ module.exports = {
         "server/**/*.js",
         "tests/dummy/config/**/*.js"
       ],
-      excludedFiles: [
-        "addon/**",
-        "addon-test-support/**",
-        "app/**",
-        "tests/dummy/app/**"
-      ],
       parserOptions: {
         sourceType: "script"
       },
@@ -61,13 +44,18 @@ module.exports = {
         {},
         require("eslint-plugin-node").configs.recommended.rules,
         {
-          // add your custom rules and overrides for node files here
-
           // this can be removed once the following is fixed
           // https://github.com/mysticatea/eslint-plugin-node/issues/77
           "node/no-unpublished-require": "off"
         }
       )
+    },
+    // testem config
+    {
+      files: ["testem.js"],
+      rules: {
+        camelcase: 0
+      }
     }
   ]
 }

embertest.js

@@ -0,0 +1,14 @@
+module.exports = {
+  root: true,
+  globals: {
+    server: true // mirage
+  },
+  env: {
+    embertest: true
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: "module"
+  },
+  extends: ["./base.js"]
+}

es5.js

@@ -1,15 +1,14 @@
 module.exports = {
+  env: {
+    browser: true
+  },
   parserOptions: {
     ecmaVersion: 5
   },
+  plugins: ["es5"],
   extends: [
     "eslint:recommended",
     "plugin:es5/no-es2015",
     "plugin:es5/no-es2016"
-  ],
-  plugins: ["es5"],
-  env: {
-    jquery: true,
-    browser: true
-  }
+  ]
 }

index.js

@@ -1,5 +1,10 @@
-"use strict"
-
 module.exports = {
-  extends: ["eslint:recommended", "./core.js"]
+  env: {
+    es6: true
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: "module"
+  },
+  extends: ["eslint:recommended", "./base.js"]
 }

node.js

@@ -0,0 +1,10 @@
+module.exports = {
+  env: {
+    node: true
+  },
+  parserOptions: {
+    ecmaVersion: 2018
+  },
+  plugins: ["node"],
+  extends: ["eslint:recommended", "plugin:node/recommended", "./base.js"]
+}

package.json

@@ -4,24 +4,24 @@
   "version": "1.7.2",
   "main": "index.js",
   "dependencies": {
+    "babel-eslint": "10.x.x",
     "eslint": "5.x.x",
-    "eslint-plugin-ember": "6.x.x",
-    "eslint-plugin-ember-suave": "1.x.x",
+    "eslint-plugin-ember-suave": "2.x.x",
     "eslint-plugin-es5": "1.x.x",
-    "eslint-plugin-node": "9.x.x",
-    "eslint-plugin-prettier": "3.x.x",
-    "prettier": "1.x.x",
+    "eslint-plugin-node": "10.x.x",
     "prettier-eslint-cli": "5.x.x"
   },
   "files": [
-    "core.js",
     "ember.js",
+    "embertest.js",
     "es5.js",
-    "index.js"
+    "index.js",
+    "node.js"
   ],
   "keywords": [
     "eslint",
-    "eslintconfig"
+    "eslintconfig",
+    "eslint-config"
   ],
   "author": "The PeopleDoc Team",
   "license": "MIT",